This is an archive of the discontinued LLVM Phabricator instance.

[Hexagon] Update include paths for linux/musl
ClosedPublic

Authored by sidneym on Apr 3 2020, 4:47 PM.

Details

Summary

Update CXX paths for linux/musl.

And update the sysroot expectation to match other targets.

At this point I might pull out the linux/musl stuff that is in hexagon-toolchain-elf.c and create a new file, hexagon-toolchain-linux.c putting the linux/musl test there.

Diff Detail

Event Timeline

sidneym created this revision.Apr 3 2020, 4:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2020, 4:47 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
sidneym updated this revision to Diff 255655.Apr 7 2020, 6:00 AM

Break out linux parts of hexagon-toolchain-elf.c into hexagon-toolchain-linux.c

sidneym updated this revision to Diff 255680.Apr 7 2020, 8:08 AM

Fix formatting issues.

bcain accepted this revision.Apr 7 2020, 11:02 AM
This revision is now accepted and ready to land.Apr 7 2020, 11:02 AM
This revision was automatically updated to reflect the committed changes.

I plan to default CMake CLANG_DEFAULT_PIE_ON_LINUX to on in D120305 and hexagon-toolchain-linux.c will fail. Do you mind investigating the issue?

Also, see D119309 for tips improving driver tests.