diff --git a/lldb/include/lldb/Core/SearchFilter.h b/lldb/include/lldb/Core/SearchFilter.h --- a/lldb/include/lldb/Core/SearchFilter.h +++ b/lldb/include/lldb/Core/SearchFilter.h @@ -98,6 +98,8 @@ /// The file spec to check against the filter. /// \return /// \b true if \a spec passes, and \b false otherwise. + /// + /// \note if not overriden, the default implementation always returns \c true. virtual bool ModulePasses(const FileSpec &spec); /// Call this method with a Module to see if that module passes the filter. @@ -107,6 +109,8 @@ /// /// \return /// \b true if \a module passes, and \b false otherwise. + /// + /// \note if not overriden, the default implementation always returns \c true. virtual bool ModulePasses(const lldb::ModuleSP &module_sp); /// Call this method with a Address to see if \a address passes the filter. @@ -116,6 +120,8 @@ /// /// \return /// \b true if \a address passes, and \b false otherwise. + /// + /// \note if not overriden, the default implementation always returns \c true. virtual bool AddressPasses(Address &addr); /// Call this method with a FileSpec to see if \a file spec passes the @@ -126,6 +132,8 @@ /// /// \return /// \b true if \a file spec passes, and \b false otherwise. + /// + /// \note if not overriden, the default implementation always returns \c true. virtual bool CompUnitPasses(FileSpec &fileSpec); /// Call this method with a CompileUnit to see if \a comp unit passes the @@ -136,6 +144,8 @@ /// /// \return /// \b true if \a Comp Unit passes, and \b false otherwise. + /// + /// \note if not overriden, the default implementation always returns \c true. virtual bool CompUnitPasses(CompileUnit &compUnit); /// Call this method with a Function to see if \a function passes the @@ -319,12 +329,6 @@ bool ModulePasses(const FileSpec &spec) override; - bool AddressPasses(Address &address) override; - - bool CompUnitPasses(FileSpec &fileSpec) override; - - bool CompUnitPasses(CompileUnit &compUnit) override; - void GetDescription(Stream *s) override; uint32_t GetFilterRequiredItems() override; @@ -370,12 +374,6 @@ bool ModulePasses(const FileSpec &spec) override; - bool AddressPasses(Address &address) override; - - bool CompUnitPasses(FileSpec &fileSpec) override; - - bool CompUnitPasses(CompileUnit &compUnit) override; - void GetDescription(Stream *s) override; uint32_t GetFilterRequiredItems() override; diff --git a/lldb/source/Core/SearchFilter.cpp b/lldb/source/Core/SearchFilter.cpp --- a/lldb/source/Core/SearchFilter.cpp +++ b/lldb/source/Core/SearchFilter.cpp @@ -412,17 +412,6 @@ return FileSpec::Match(m_module_spec, spec); } -bool SearchFilterByModule::AddressPasses(Address &address) { - // FIXME: Not yet implemented - return true; -} - -bool SearchFilterByModule::CompUnitPasses(FileSpec &fileSpec) { return true; } - -bool SearchFilterByModule::CompUnitPasses(CompileUnit &compUnit) { - return true; -} - void SearchFilterByModule::Search(Searcher &searcher) { if (!m_target_sp) return; @@ -538,19 +527,6 @@ return m_module_spec_list.FindFileIndex(0, spec, true) != UINT32_MAX; } -bool SearchFilterByModuleList::AddressPasses(Address &address) { - // FIXME: Not yet implemented - return true; -} - -bool SearchFilterByModuleList::CompUnitPasses(FileSpec &fileSpec) { - return true; -} - -bool SearchFilterByModuleList::CompUnitPasses(CompileUnit &compUnit) { - return true; -} - void SearchFilterByModuleList::Search(Searcher &searcher) { if (!m_target_sp) return;