Page MenuHomePhabricator

Augment the symbol type classification for dyld trie exports with more detail
ClosedPublic

Authored by jasonmolenda on Apr 2 2020, 10:37 PM.

Details

Summary

My patch to augment the symbol table in Mach-O files with the dyld trie exports data structure only categorized symbols as code or data, but Greg Clayton had a patch to do something similar to swift a few years ago that had a more extensive categorization of symbols, as well as extracting some objc class/ivar names from the entries. This patch is basically just Greg's, updated a bit and with a test case added to it.

I'm most interested for any better ideas for a test where I get two symbols by a name search, and want to verify that one symbol has an objc type and the other symbol has a second objc type, it doesn't matter the order of the symbols returned. The test case addition works, but it's not pretty - I was trying to think of a better way to do this but didn't come up with anything in the moment.

Diff Detail

Event Timeline

jasonmolenda created this revision.Apr 2 2020, 10:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 6 2020, 2:12 PM
This revision was automatically updated to reflect the committed changes.