diff --git a/llvm/lib/Support/CommandLine.cpp b/llvm/lib/Support/CommandLine.cpp --- a/llvm/lib/Support/CommandLine.cpp +++ b/llvm/lib/Support/CommandLine.cpp @@ -1581,9 +1581,9 @@ } else { assert(ConsumeAfterOpt && NumPositionalRequired <= PositionalVals.size()); unsigned ValNo = 0; - for (size_t j = 1, e = PositionalOpts.size(); j != e; ++j) - if (RequiresValue(PositionalOpts[j])) { - ErrorParsing |= ProvidePositionalOption(PositionalOpts[j], + for (size_t J = 0, E = PositionalOpts.size(); J != E; ++J) + if (RequiresValue(PositionalOpts[J])) { + ErrorParsing |= ProvidePositionalOption(PositionalOpts[J], PositionalVals[ValNo].first, PositionalVals[ValNo].second); ValNo++; diff --git a/llvm/unittests/Support/CommandLineTest.cpp b/llvm/unittests/Support/CommandLineTest.cpp --- a/llvm/unittests/Support/CommandLineTest.cpp +++ b/llvm/unittests/Support/CommandLineTest.cpp @@ -1793,4 +1793,49 @@ clEnumValN(Val1, "bits-val1", "The Val1 value"), clEnumValN(Val1, "bits-val2", "The Val2 value"))); +TEST(CommandLineTest, ConsumeAfterOnePositional) { + cl::ResetCommandLineParser(); + + // input [args] + StackOption> Input(cl::Positional, + cl::Required); + StackOption> ExtraArgs(cl::ConsumeAfter); + + const char *Args[] = {"prog", "input", "arg1", "arg2"}; + + std::string Errs; + raw_string_ostream OS(Errs); + EXPECT_TRUE(cl::ParseCommandLineOptions(4, Args, StringRef(), &OS)); + OS.flush(); + EXPECT_EQ("input", Input); + EXPECT_TRUE(ExtraArgs.size() == 2); + EXPECT_TRUE(ExtraArgs[0] == "arg1"); + EXPECT_TRUE(ExtraArgs[1] == "arg2"); + EXPECT_TRUE(Errs.empty()); +} + +TEST(CommandLineTest, ConsumeAfterTwoPositionals) { + cl::ResetCommandLineParser(); + + // input1 input2 [args] + StackOption> Input1(cl::Positional, + cl::Required); + StackOption> Input2(cl::Positional, + cl::Required); + StackOption> ExtraArgs(cl::ConsumeAfter); + + const char *Args[] = {"prog", "input1", "input2", "arg1", "arg2"}; + + std::string Errs; + raw_string_ostream OS(Errs); + EXPECT_TRUE(cl::ParseCommandLineOptions(5, Args, StringRef(), &OS)); + OS.flush(); + EXPECT_EQ("input1", Input1); + EXPECT_EQ("input2", Input2); + EXPECT_TRUE(ExtraArgs.size() == 2); + EXPECT_TRUE(ExtraArgs[0] == "arg1"); + EXPECT_TRUE(ExtraArgs[1] == "arg2"); + EXPECT_TRUE(Errs.empty()); +} + } // anonymous namespace