This is an archive of the discontinued LLVM Phabricator instance.

Differential D7693

[lld][ELF] Demangle: don't expose raw info when getter is available.
ClosedPublic

Authored by davide on Feb 16 2015, 9:21 PM.

Details

Reviewers
• shankar.easwaran
Commits
rG6d86bb2f8b11: [ELF] Demangle: don't expose raw info when getter is available.
rLLD229635: [ELF] Demangle: don't expose raw info when getter is available.
Summary

Shankar, I like to use getter/setter everywhere better. If you disagree, I'll withdrawn the revision.

Diff Detail

Event Timeline

davide updated this revision to Diff 20066.Feb 16 2015, 9:21 PM
davide retitled this revision from to [lld][ELF] Demangle: don't expose raw info when getter is available..
davide updated this object.
davide edited the test plan for this revision. (Show Details)
davide added a reviewer: • shankar.easwaran.
davide set the repository for this revision to rL LLVM.
davide added a project: lld.
davide added subscribers: Unknown Object (MLST), emaste.
• shankar.easwaran accepted this revision.Feb 17 2015, 5:25 AM
• shankar.easwaran edited edge metadata.

lgtm

This revision is now accepted and ready to land.Feb 17 2015, 5:25 AM
davide closed this revision.Feb 17 2015, 7:56 PM
davide mentioned this in rL229635: [ELF] Demangle: don't expose raw info when getter is available..Feb 17 2015, 7:56 PM

Revision Contents

PathSize
lib/
ReaderWriter/
ELF/
2 lines
MachO/
2 lines

Diff 20066

lib/ReaderWriter/ELF/ELFLinkingContext.cpp

Context not available.
} }
std::string ELFLinkingContext::demangle(StringRef symbolName) const { std::string ELFLinkingContext::demangle(StringRef symbolName) const {
if (!_demangle) if (!demangleSymbols())
return symbolName; return symbolName;
// Only try to demangle symbols that look like C++ symbols // Only try to demangle symbols that look like C++ symbols
Context not available.

lib/ReaderWriter/MachO/MachOLinkingContext.cpp

Context not available.
std::string MachOLinkingContext::demangle(StringRef symbolName) const { std::string MachOLinkingContext::demangle(StringRef symbolName) const {
// Only try to demangle symbols if -demangle on command line // Only try to demangle symbols if -demangle on command line
if (!_demangle) if (!demangleSymbols())
return symbolName; return symbolName;
// Only try to demangle symbols that look like C++ symbols // Only try to demangle symbols that look like C++ symbols
Context not available.