diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp b/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp --- a/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp +++ b/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp @@ -125,6 +125,10 @@ for (auto T : {MVT::v16i8, MVT::v8i16}) setOperationAction(Op, T, Legal); + // Support integer abs + for (auto T : {MVT::v16i8, MVT::v8i16, MVT::v4i32}) + setOperationAction(ISD::ABS, T, Legal); + // Custom lower BUILD_VECTORs to minimize number of replace_lanes for (auto T : {MVT::v16i8, MVT::v8i16, MVT::v4i32, MVT::v4f32, MVT::v2i64, MVT::v2f64}) diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td b/llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td --- a/llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td +++ b/llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td @@ -575,6 +575,11 @@ // Integer vector negation def ivneg : PatFrag<(ops node:$in), (sub immAllZerosV, node:$in)>; +// Integer absolute value: abs +defm ABS : SIMDUnary; +defm ABS : SIMDUnary; +defm ABS : SIMDUnary; + // Integer negation: neg defm NEG : SIMDUnaryInt; diff --git a/llvm/test/CodeGen/WebAssembly/simd-arith.ll b/llvm/test/CodeGen/WebAssembly/simd-arith.ll --- a/llvm/test/CodeGen/WebAssembly/simd-arith.ll +++ b/llvm/test/CodeGen/WebAssembly/simd-arith.ll @@ -118,6 +118,18 @@ ret <16 x i8> %c } +; CHECK-LABEL: abs_v16i8: +; NO-SIMD128-NOT: i8x16 +; SIMD128-NEXT: .functype abs_v16i8 (v128) -> (v128){{$}} +; SIMD128-NEXT: i8x16.abs $push[[R:[0-9]+]]=, $0{{$}} +; SIMD128-NEXT: return $pop[[R]]{{$}} +define <16 x i8> @abs_v16i8(<16 x i8> %x) { + %a = sub <16 x i8> zeroinitializer, %x + %b = icmp slt <16 x i8> %x, zeroinitializer + %c = select <16 x i1> %b, <16 x i8> %a, <16 x i8> %x + ret <16 x i8> %c +} + ; CHECK-LABEL: neg_v16i8: ; NO-SIMD128-NOT: i8x16 ; SIMD128-NEXT: .functype neg_v16i8 (v128) -> (v128){{$}} @@ -431,6 +443,18 @@ ret <8 x i16> %c } +; CHECK-LABEL: abs_v8i16: +; NO-SIMD128-NOT: i16x8 +; SIMD128-NEXT: .functype abs_v8i16 (v128) -> (v128){{$}} +; SIMD128-NEXT: i16x8.abs $push[[R:[0-9]+]]=, $0{{$}} +; SIMD128-NEXT: return $pop[[R]]{{$}} +define <8 x i16> @abs_v8i16(<8 x i16> %x) { + %a = sub <8 x i16> zeroinitializer, %x + %b = icmp slt <8 x i16> %x, zeroinitializer + %c = select <8 x i1> %b, <8 x i16> %a, <8 x i16> %x + ret <8 x i16> %c +} + ; CHECK-LABEL: neg_v8i16: ; NO-SIMD128-NOT: i16x8 ; SIMD128-NEXT: .functype neg_v8i16 (v128) -> (v128){{$}} @@ -713,6 +737,18 @@ ret <4 x i32> %a } +; CHECK-LABEL: abs_v4i32: +; NO-SIMD128-NOT: i32x4 +; SIMD128-NEXT: .functype abs_v4i32 (v128) -> (v128){{$}} +; SIMD128-NEXT: i32x4.abs $push[[R:[0-9]+]]=, $0{{$}} +; SIMD128-NEXT: return $pop[[R]]{{$}} +define <4 x i32> @abs_v4i32(<4 x i32> %x) { + %a = sub <4 x i32> zeroinitializer, %x + %b = icmp slt <4 x i32> %x, zeroinitializer + %c = select <4 x i1> %b, <4 x i32> %a, <4 x i32> %x + ret <4 x i32> %c +} + ; CHECK-LABEL: neg_v4i32: ; NO-SIMD128-NOT: i32x4 ; SIMD128-NEXT: .functype neg_v4i32 (v128) -> (v128){{$}} diff --git a/llvm/test/MC/WebAssembly/simd-encodings.s b/llvm/test/MC/WebAssembly/simd-encodings.s --- a/llvm/test/MC/WebAssembly/simd-encodings.s +++ b/llvm/test/MC/WebAssembly/simd-encodings.s @@ -580,6 +580,15 @@ # CHECK: i32x4.dot_i16x8_s # encoding: [0xfd,0xdb,0x01] i32x4.dot_i16x8_s + # CHECK: i8x16.abs # encoding: [0xfd,0xe1,0x01] + i8x16.abs + + # CHECK: i16x8.abs # encoding: [0xfd,0xe2,0x01] + i16x8.abs + + # CHECK: i32x4.abs # encoding: [0xfd,0xe3,0x01] + i32x4.abs + # CHECK: i8x16.bitmask # encoding: [0xfd,0xe4,0x01] i8x16.bitmask