This is an archive of the discontinued LLVM Phabricator instance.

Differential D76189

[Fuchsia] Use -ffile-prefix-map
ClosedPublic

Authored by phosek on Mar 14 2020, 9:09 PM.

Details

Reviewers
leonardchan
Commits
rG98223f7931f2: [Fuchsia] Use -ffile-prefix-map
Summary

This makes toolchain independent of the path it was built in by
rewriting all absolute paths embedded in sources and debug info
into relative ones.

Diff Detail

Event Timeline

phosek created this revision.Mar 14 2020, 9:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2020, 9:09 PM
Herald added subscribers: cfe-commits, aprantl, mgorny. · View Herald Transcript
Harbormaster completed remote builds in B49240: Diff 250401.Mar 14 2020, 10:02 PM
leonardchan accepted this revision.Mar 16 2020, 12:11 PM
This revision is now accepted and ready to land.Mar 16 2020, 12:11 PM
Closed by commit rG98223f7931f2: [Fuchsia] Use -ffile-prefix-map (authored by phosek). · Explain WhyMar 19 2020, 3:23 PM
This revision was automatically updated to reflect the committed changes.
dblaikie added a subscriber: dblaikie.Mar 21 2020, 8:09 PM

@leonardchan sorry for the inconvenience, but Phabricator has a bug/missing feature where it doesn't send mail for bug updates that contain no user-authored text, so approving a patch without writing anything in the text box doesn't send an email to the mailing lrist (the mailing list is still considered the canonical source of truth for reviews, etc) and thus makes it looks like patches are being committed without review. When approving a patch through phab, please write something (eg: "Thanks!", "Looks good!", etc) in the text box to workaround this bug.

dblaikie mentioned this in D75684: [mlir][LLVM] Remove pessimizing std::move..Mar 27 2020, 1:51 PM

Revision Contents

PathSize
clang/
cmake/
caches/
2 lines

Diff 251491

clang/cmake/caches/Fuchsia-stage2.cmake

Show All 10 Lines
set(LLVM_ENABLE_LTO ON CACHE BOOL "") set(LLVM_ENABLE_LTO ON CACHE BOOL "")
set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR ON CACHE BOOL "") set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR ON CACHE BOOL "")
set(LLVM_ENABLE_TERMINFO OFF CACHE BOOL "") set(LLVM_ENABLE_TERMINFO OFF CACHE BOOL "")
set(LLVM_ENABLE_UNWIND_TABLES OFF CACHE BOOL "") set(LLVM_ENABLE_UNWIND_TABLES OFF CACHE BOOL "")
set(LLVM_ENABLE_ZLIB ON CACHE BOOL "") set(LLVM_ENABLE_ZLIB ON CACHE BOOL "")
set(LLVM_INCLUDE_DOCS OFF CACHE BOOL "") set(LLVM_INCLUDE_DOCS OFF CACHE BOOL "")
set(LLVM_INCLUDE_EXAMPLES OFF CACHE BOOL "") set(LLVM_INCLUDE_EXAMPLES OFF CACHE BOOL "")
set(LLVM_INCLUDE_GO_TESTS OFF CACHE BOOL "") set(LLVM_INCLUDE_GO_TESTS OFF CACHE BOOL "")
set(LLVM_USE_RELATIVE_PATHS_IN_DEBUG_INFO ON CACHE BOOL "") set(LLVM_USE_RELATIVE_PATHS_IN_FILES ON CACHE BOOL "")
set(CLANG_DEFAULT_CXX_STDLIB libc++ CACHE STRING "") set(CLANG_DEFAULT_CXX_STDLIB libc++ CACHE STRING "")
if(NOT APPLE) if(NOT APPLE)
set(CLANG_DEFAULT_LINKER lld CACHE STRING "") set(CLANG_DEFAULT_LINKER lld CACHE STRING "")
set(CLANG_DEFAULT_OBJCOPY llvm-objcopy CACHE STRING "") set(CLANG_DEFAULT_OBJCOPY llvm-objcopy CACHE STRING "")
endif() endif()
set(CLANG_DEFAULT_RTLIB compiler-rt CACHE STRING "") set(CLANG_DEFAULT_RTLIB compiler-rt CACHE STRING "")
set(CLANG_ENABLE_ARCMT OFF CACHE BOOL "") set(CLANG_ENABLE_ARCMT OFF CACHE BOOL "")
▲ Show 20 Lines • Show All 203 Lines • Show Last 20 Lines