Page MenuHomePhabricator

Allow site-specific test_exec_root.
ClosedPublic

Authored by danalbert on Mar 12 2020, 12:18 PM.

Details

Reviewers
EricWF
mclow.lists
ldionne
Group Reviewers
Restricted Project
Commits
rG14d2d8c9761b: Allow site-specific test_exec_root.

Diff Detail

Event Timeline

danalbert created this revision.Mar 12 2020, 12:18 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne added inline comments.
libcxx/test/lit.cfg
41–42

I haven't come across the test_exec_root yet, what is it used for? I grepped but couldn't find out.

danalbert marked 2 inline comments as done.Mar 12 2020, 5:30 PM
danalbert added inline comments.
libcxx/test/lit.cfg
41–42

The cwd for compilation is one use. Not sure if there are others. We override this in Android because our obj root (libc++ install location) and the test location is not the same.

danalbert marked an inline comment as done.Mar 12 2020, 5:34 PM
ldionne accepted this revision.Mar 13 2020, 10:28 AM
ldionne added inline comments.
libcxx/test/lit.cfg
41–42

Do you have a publicly visible tester that uses this? I'm asking because I'd like to improve the CMake/lit interaction in the coming weeks, and I want to be able to see when I break you.

This revision is now accepted and ready to land.Mar 13 2020, 10:28 AM
This revision was automatically updated to reflect the committed changes.