Index: source/API/SBFileSpec.cpp =================================================================== --- source/API/SBFileSpec.cpp +++ source/API/SBFileSpec.cpp @@ -94,7 +94,7 @@ llvm::SmallString<64> result(src_path); lldb_private::FileSpec::Resolve (result); size_t result_length = std::min(dst_len-1, result.size()); - ::strncpy(dst_path, result.c_str(), result_length + 1); + ::snprintf(dst_path, result_length + 1, "%s", result.c_str()); return result_length; } Index: source/Host/common/FileSpec.cpp =================================================================== --- source/Host/common/FileSpec.cpp +++ source/Host/common/FileSpec.cpp @@ -795,7 +795,7 @@ std::string result = GetPath(denormalize); size_t result_length = std::min(path_max_len-1, result.length()); - ::strncpy(path, result.c_str(), result_length + 1); + ::snprintf(path, result_length + 1, "%s", result.c_str()); return result_length; } Index: source/Host/common/SocketAddress.cpp =================================================================== --- source/Host/common/SocketAddress.cpp +++ source/Host/common/SocketAddress.cpp @@ -48,8 +48,7 @@ const char* formatted = inet_ntoa(*static_cast(src)); if (formatted && strlen(formatted) < size) { - strncpy(dst, formatted, size); - return dst; + return ::strcpy(dst, formatted); } } return nullptr; @@ -64,8 +63,7 @@ ); if (full_size < static_cast(size)) { - strncpy(dst,tmp,size); - return dst; + return ::strcpy(dst, tmp); } return nullptr; } Index: source/Host/macosx/HostInfoMacOSX.mm =================================================================== --- source/Host/macosx/HostInfoMacOSX.mm +++ source/Host/macosx/HostInfoMacOSX.mm @@ -134,22 +134,25 @@ FileSpec lldb_file_spec; if (!GetLLDBPath(lldb::ePathTypeLLDBShlibDir, lldb_file_spec)) return false; - char raw_path[PATH_MAX]; - lldb_file_spec.GetPath(raw_path, sizeof(raw_path)); + std::string raw_path_str = lldb_file_spec.GetPath(); + llvm::SmallString raw_path(llvm::StringRef(raw_path_str.c_str(), raw_path_str.size())); + llvm::StringRef raw_path_ref = raw_path.str(); - char *framework_pos = ::strstr(raw_path, "LLDB.framework"); - if (framework_pos) + size_t framework_pos = raw_path.find("LLDB.framework"); + if (framework_pos != llvm::StringRef::npos) { framework_pos += strlen("LLDB.framework"); #if defined(__arm__) || defined(__arm64__) || defined(__aarch64__) // Shallow bundle - *framework_pos = '\0'; + raw_path_ref = raw_path_ref.slice(0, framework_pos); #else // Normal bundle - ::strncpy(framework_pos, "/Resources", PATH_MAX - (framework_pos - raw_path)); + raw_path.assign(raw_path_ref.slice(0, framework_pos)); + raw_path.append(llvm::StringRef("/Resources", strlen("/Resources"))); + raw_path_ref = raw_path.str(); #endif } - file_spec.GetDirectory().SetCString(raw_path); + file_spec.GetDirectory().SetString(raw_path_ref); return (bool)file_spec.GetDirectory(); } @@ -167,7 +170,7 @@ if (framework_pos) { framework_pos += strlen("LLDB.framework"); - ::strncpy(framework_pos, "/Headers", PATH_MAX - (framework_pos - raw_path)); + ::snprintf(framework_pos, PATH_MAX - (framework_pos - raw_path), "/Headers"); } file_spec.GetDirectory().SetCString(raw_path); return true; @@ -188,7 +191,7 @@ if (framework_pos) { framework_pos += strlen("LLDB.framework"); - ::strncpy(framework_pos, "/Resources/Python", PATH_MAX - (framework_pos - raw_path)); + ::snprintf(framework_pos, PATH_MAX - (framework_pos - raw_path), "/Resources/Python"); } else { @@ -221,7 +224,7 @@ if (framework_pos) { framework_pos += strlen("LLDB.framework"); - ::strncpy (framework_pos, "/Resources/Clang", PATH_MAX - (framework_pos - raw_path)); + ::snprintf(framework_pos, PATH_MAX - (framework_pos - raw_path), "/Resources/Clang"); } file_spec.SetFile (raw_path, true); return true; @@ -241,7 +244,7 @@ return false; framework_pos += strlen("LLDB.framework"); - ::strncpy(framework_pos, "/Resources/PlugIns", PATH_MAX - (framework_pos - raw_path)); + ::snprintf(framework_pos, PATH_MAX - (framework_pos - raw_path), "/Resources/PlugIns"); file_spec.GetDirectory().SetCString(raw_path); return true; } Index: source/Host/posix/HostInfoPosix.cpp =================================================================== --- source/Host/posix/HostInfoPosix.cpp +++ source/Host/posix/HostInfoPosix.cpp @@ -153,11 +153,8 @@ char *lib_pos = ::strstr(raw_path, "/lib"); if (lib_pos != nullptr) { - // First terminate the raw path at the start of lib. - *lib_pos = '\0'; - // Now write in bin in place of lib. - ::strncpy(lib_pos, "/bin", PATH_MAX - (lib_pos - raw_path)); + ::snprintf(lib_pos, PATH_MAX - (lib_pos - raw_path), "/bin"); if (log) log->Printf("Host::%s() derived the bin path as: %s", __FUNCTION__, raw_path); Index: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp =================================================================== --- source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp +++ source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp @@ -3639,7 +3639,7 @@ if (thread_suffix_supported) ::snprintf (packet, sizeof(packet), "QSaveRegisterState;thread:%4.4" PRIx64 ";", tid); else - ::strncpy (packet, "QSaveRegisterState", sizeof(packet)); + ::snprintf(packet, sizeof(packet), "QSaveRegisterState"); StringExtractorGDBRemote response; Index: source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp =================================================================== --- source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp +++ source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp @@ -231,7 +231,7 @@ const char *node_content = (const char *)::xmlNodeGetContent(value_node); if (node_content) { - strncpy(DBGBuildSourcePath, node_content, sizeof(DBGBuildSourcePath)); + ::snprintf(DBGBuildSourcePath, sizeof(DBGBuildSourcePath), "%s", node_content); xmlFree((void *) node_content); } } Index: source/lldb.cpp =================================================================== --- source/lldb.cpp +++ source/lldb.cpp @@ -364,13 +364,13 @@ const char *newline_loc = strchr(version_string, '\n'); - size_t version_len = sizeof(g_version_string); + size_t version_len = sizeof(g_version_string) - 1; if (newline_loc && (newline_loc - version_string < static_cast(version_len))) version_len = newline_loc - version_string; - ::strncpy(g_version_string, version_string, version_len); + ::snprintf(g_version_string, version_len + 1, "%s", version_string); } return g_version_string;