Page MenuHomePhabricator

Added support for 'su' rooted devices to ASAN setup script
ClosedPublic

Authored by ripp on Feb 11 2015, 1:23 AM.

Details

Reviewers
eugenis
Summary

Android devices may not support 'adb root', but be rooted with 'su' binary. This patch make possible to install ASAN to such devices.
When --use-su flag is specified, most 'adb ...' commangs are changed to 'adb su -c "..."'.

Some other notes:

  • 'readlink' changed to 'ls -l', since not all devices have readlink in their firmware.
  • removing ASAN library step moved to very end, because 'su' may not run properly without this library until shell will be restarted

Diff Detail

Event Timeline

ripp updated this revision to Diff 19732.Feb 11 2015, 1:23 AM
ripp retitled this revision from to Added support for 'su' rooted devices to ASAN setup script.
ripp updated this object.
ripp edited the test plan for this revision. (Show Details)
ripp added a reviewer: eugenis.
ripp added a subscriber: Unknown Object (MLST).
eugenis accepted this revision.Feb 16 2015, 1:18 AM
eugenis edited edge metadata.

LGTM
Do you want to me land this change for you?

This revision is now accepted and ready to land.Feb 16 2015, 1:18 AM
ripp added a comment.Feb 16 2015, 1:57 AM

Yes, do the landing please.
Thank you

eugenis closed this revision.Feb 16 2015, 2:25 AM

Committed in r229368.
Thanks for the patch!