Page MenuHomePhabricator

[buildbot] Add an MLIR buildbot on Windows
ClosedPublic

Authored by stella.stamenova on Mar 2 2020, 5:17 PM.

Details

Summary

This adds a Buildbot for MLIR on Windows

Diff Detail

Event Timeline

@gkistanova: We have the machine setup to connect to silent master (buildmaster_host = 'lab.llvm.org', port = 9994) as we expect some failures. Let me know if we need to do anything else other than commit the patch and wait for a reboot. Thanks!

Fantastic! Thanks for contributing this :)

buildbot/osuosl/master/config/builders.py
1078

Can we add nvptx and amdgpu?

There are passes that only build and runs with these targets configured in (but don’t require anything else at runtime).
That would increase the coverage for the project.

1079

I don’t know if there is a way to filter the build targets: you likely could only run check-mlir instead of check-all

gkistanova accepted this revision.Mar 3 2020, 7:26 PM

Thanks, Stella!

Let me know if we need to do anything else other than commit the patch and wait for a reboot.

You should be good after the commit and build bot restart with your changes.

buildbot/osuosl/master/config/builders.py
1079

Yes. One could use the checks parameter and pass a list of check targets. Like

UnifiedTreeBuilder.getCmakeWithNinjaWithMSVCBuildFactory(
    ...
    checks=['check-mlir'],
    ...
)
This revision is now accepted and ready to land.Mar 3 2020, 7:26 PM
gkistanova added inline comments.Mar 3 2020, 7:37 PM
buildbot/osuosl/master/config/builders.py
1078

This is cosmetic. I don't think you need quotation marks around 'host'.

Add AMDGPU and NVPTX to the targets

Make check-mlir be the only checks that run

This revision was automatically updated to reflect the committed changes.