Page MenuHomePhabricator

p[LIBOMPTARGET]Lower priority of global constructor/destructor to silence the warning from gcc.
ClosedPublic

Authored by ABataev on Mar 2 2020, 7:30 AM.

Details

Summary

fixed the warning from gcc since prios 0-100 are reserved for the internal use.

Diff Detail

Event Timeline

ABataev created this revision.Mar 2 2020, 7:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2020, 7:30 AM
grokos accepted this revision.Mar 2 2020, 11:09 AM

Looks good. Do you think I should also change the priorities in my clang-offload-wrapper patch to be out of the reserved range?
https://reviews.llvm.org/D75223

This revision is now accepted and ready to land.Mar 2 2020, 11:09 AM

Looks good. Do you think I should also change the priorities in my clang-offload-wrapper patch to be out of the reserved range?
https://reviews.llvm.org/D75223

Not sure. Of course, it would be good to avoid using some of the reserved ranges but in case of the wrapper it should not be a real issue. Gcc reserves it for the compiler use, so wrapper must be good here (as it is a part of the compiler).

This revision was automatically updated to reflect the committed changes.