Page MenuHomePhabricator

Add thread-id field in *stopped notification (MI)
ClosedPublic

Authored by ki.stfu on Feb 9 2015, 6:29 AM.

Diff Detail

Event Timeline

ki.stfu updated this revision to Diff 19578.Feb 9 2015, 6:29 AM
ki.stfu retitled this revision from to Add thread-id field in *stopped notification (MI).
ki.stfu updated this object.
ki.stfu edited the test plan for this revision. (Show Details)
ki.stfu added reviewers: abidh, clayborg, zturner.
ki.stfu added subscribers: abidh, clayborg, zturner, Unknown Object (MLST).
abidh edited edge metadata.Feb 9 2015, 10:41 AM

Looks ok to me. Please note that I made a small change in this test earlier today. On Linux, the stop reason is different and the test was failing. I am now only checking only for the *stopped. I then run to main to make sure that we have not run to the end. But test can be changed to ignore stop reason and still check for thread id.

clayborg accepted this revision.Feb 9 2015, 11:07 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Feb 9 2015, 11:07 AM
In D7501#120702, @abidh wrote:

On Linux, the stop reason is different and the test was failing. I am now only checking only for the *stopped. I then run to main to make sure that we have not run to the end. But test can be changed to ignore stop reason and still check for thread id.

What is the stop reason on Linux? Is not it "signal-received"?

abidh added a comment.Feb 10 2015, 1:25 AM

What is the stop reason on Linux? Is not it "signal-received"?

In Command line lldb:
process launch -s
Process 20587 launching
Process 20587 launched: '/home/abidh/demos/struct' (x86_64)
Process 20587 stopped

  • thread #1: tid = 20587, 0x00007ffff7ddb2d0, name = 'struct', stop reason = trace

In lldb-mi:
*stopped,reason="end-stepping-range",frame={addr="0x7ffff7ddb2d0",func="??",args=[],file="??",fullname="??",line="-1"},thread-id="1",stopped-threads="all"

ki.stfu updated this revision to Diff 19661.Feb 10 2015, 4:02 AM
ki.stfu edited edge metadata.

Update test after r228584

ki.stfu closed this revision.Feb 10 2015, 4:03 AM