This is an archive of the discontinued LLVM Phabricator instance.

[DebugInfo] Remove a misleading comment for llvm::dwarf::FDE.
ClosedPublic

Authored by ikudrin on Feb 18 2020, 5:46 AM.

Details

Summary

The comment described a linked CIE to be acquired lazily. That is not true and looks like it was never true.

Notes. The comment was initially added in https://reviews.llvm.org/rGfd08bc195b36b2262f9ee4b283eef44b0520ebed and was moved into its current location in https://reviews.llvm.org/D43313.

Diff Detail

Event Timeline

ikudrin created this revision.Feb 18 2020, 5:46 AM
jhenderson accepted this revision.Feb 18 2020, 7:02 AM

LGTM, but it might be worth waiting for somebody else with more familiarity with the debug frame code to confirm it makes sense.

This revision is now accepted and ready to land.Feb 18 2020, 7:02 AM

It looks like nobody else is willing to comment, so I am applying this.

This revision was automatically updated to reflect the committed changes.