Index: lib/Analysis/BasicAliasAnalysis.cpp =================================================================== --- lib/Analysis/BasicAliasAnalysis.cpp +++ lib/Analysis/BasicAliasAnalysis.cpp @@ -997,6 +997,77 @@ "DecomposeGEPExpression and GetUnderlyingObject disagree!"); return MayAlias; } + + // If both GEPs are based on the same pointer, and said pointer is a + // (possibly multidimensional) array of structs, we can try to determine + // whether struct field accesses don't alias. + // Note that the same pointer the GEPs are based on has to be the same + // pointer operand, not just the same underlying object. + // We also need at least two indices (the pointer, and the struct field). + if (GEP1->getPointerOperand() == GEP2->getPointerOperand() && + GEP1->getNumIndices() == GEP2->getNumIndices() && + GEP1->getNumIndices() >= 2) { + + ConstantInt *C1 = + dyn_cast(GEP1->getOperand(GEP1->getNumOperands() - 1)); + ConstantInt *C2 = + dyn_cast(GEP2->getOperand(GEP2->getNumOperands() - 1)); + + // Find the last-indexed type of the GEP, i.e., the type you'd get if + // you stripped the last index. + // On the way, look at each indexed type. If there's something other + // than an array, different indices can lead to different final types. + auto LookThroughArrayIndices = [](const GEPOperator *GEP) -> StructType *{ + SmallVector IntermediateIndices; + assert(GEP->getNumIndices() > 1 && + "Not enough GEP indices to examine"); + + // Insert the first index; we don't need to check the type indexed + // through as it only drops the pointer indirection. + IntermediateIndices.push_back(GEP->getOperand(1)); + + // Insert all the remaining indices but the last one. + // Also, check that they all index through arrays. + for (unsigned i = 1, e = GEP->getNumIndices() - 1; i != e; ++i) { + if (!isa(GetElementPtrInst::getIndexedType( + GEP->getPointerOperandType(), IntermediateIndices))) + return nullptr; + IntermediateIndices.push_back(GEP->getOperand(i + 1)); + } + return dyn_cast(GetElementPtrInst::getIndexedType( + GEP->getPointerOperandType(), IntermediateIndices)); + }; + + StructType *LastIndexedStruct = nullptr; + + // If the last indices in both GEPs are constant, and they index into + // a struct, we can try to figure out if they access different fields. + // Because both GEPs begin indexing from the exact same pointer, and only + // index through arrays prior to the constant index into a struct, the + // struct that GEP1 indexes into and the struct that GEP2 indexes into + // must either precisely overlap or be completely disjoint. Because they + // cannot partially overlap, indexing into different non-overlapping + // fields of the struct will never alias. + if (C1 && C2 && C1 != C2 && + (LastIndexedStruct = LookThroughArrayIndices(GEP1))) { + const StructLayout *SL = DL->getStructLayout(LastIndexedStruct); + const uint64_t StructSize = SL->getSizeInBytes(); + const uint64_t V1Off = SL->getElementOffset(C1->getZExtValue()); + const uint64_t V2Off = SL->getElementOffset(C2->getZExtValue()); + + auto EltsDontOverlap = [StructSize](uint64_t V1Off, uint64_t V2Off, + uint64_t V1Size, uint64_t V2Size) { + return V1Off < V2Off && V1Off + V1Size <= V2Off && + ((V2Off + V2Size <= StructSize) || + (V2Off + V2Size - StructSize <= V1Off)); + }; + + if (EltsDontOverlap(V1Off, V2Off, V1Size, V2Size) || + EltsDontOverlap(V2Off, V1Off, V2Size, V1Size)) + return NoAlias; + } + } + // If the max search depth is reached the result is undefined if (GEP2MaxLookupReached || GEP1MaxLookupReached) return MayAlias; Index: test/Analysis/BasicAA/struct-geps.ll =================================================================== --- /dev/null +++ test/Analysis/BasicAA/struct-geps.ll @@ -0,0 +1,133 @@ +; RUN: opt < %s -basicaa -aa-eval -print-all-alias-modref-info -disable-output 2>&1 | FileCheck %s + +target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" +target triple = "x86_64-apple-darwin" + +%struct = type { i32, i32, i32 } + +; CHECK-LABEL: test_simple + +; CHECK-DAG: PartialAlias: %struct* %st, i32* %x +; CHECK-DAG: PartialAlias: %struct* %st, i32* %y +; CHECK-DAG: PartialAlias: %struct* %st, i32* %z + +; CHECK-DAG: NoAlias: i32* %x, i32* %y +; CHECK-DAG: NoAlias: i32* %x, i32* %z +; CHECK-DAG: NoAlias: i32* %y, i32* %z + +; CHECK-DAG: PartialAlias: %struct* %st, %struct* %y_12 +; CHECK-DAG: PartialAlias: %struct* %y_12, i32* %x +; CHECK-DAG: PartialAlias: i32* %x, i80* %y_10 + +; CHECK-DAG: PartialAlias: %struct* %st, i64* %y_8 +; CHECK-DAG: PartialAlias: i32* %z, i64* %y_8 +; CHECK-DAG: NoAlias: i32* %x, i64* %y_8 + +; CHECK-DAG: MustAlias: %struct* %y_12, i32* %y +; CHECK-DAG: MustAlias: i32* %y, i64* %y_8 +; CHECK-DAG: MustAlias: i32* %y, i80* %y_10 + +define void @test_simple(%struct* %st, i64 %i, i64 %j, i64 %k) { + %x = getelementptr %struct* %st, i64 %i, i32 0 + %y = getelementptr %struct* %st, i64 %j, i32 1 + %z = getelementptr %struct* %st, i64 %k, i32 2 + %y_12 = bitcast i32* %y to %struct* + %y_10 = bitcast i32* %y to i80* + %y_8 = bitcast i32* %y to i64* + ret void +} + +; CHECK-LABEL: test_in_array + +; CHECK-DAG: PartialAlias: [1 x %struct]* %st, i32* %x +; CHECK-DAG: PartialAlias: [1 x %struct]* %st, i32* %y +; CHECK-DAG: PartialAlias: [1 x %struct]* %st, i32* %z + +; CHECK-DAG: NoAlias: i32* %x, i32* %y +; CHECK-DAG: NoAlias: i32* %x, i32* %z +; CHECK-DAG: NoAlias: i32* %y, i32* %z + +; CHECK-DAG: PartialAlias: %struct* %y_12, [1 x %struct]* %st +; CHECK-DAG: PartialAlias: %struct* %y_12, i32* %x +; CHECK-DAG: PartialAlias: i32* %x, i80* %y_10 + +; CHECK-DAG: PartialAlias: [1 x %struct]* %st, i64* %y_8 +; CHECK-DAG: PartialAlias: i32* %z, i64* %y_8 +; CHECK-DAG: NoAlias: i32* %x, i64* %y_8 + +; CHECK-DAG: MustAlias: %struct* %y_12, i32* %y +; CHECK-DAG: MustAlias: i32* %y, i64* %y_8 +; CHECK-DAG: MustAlias: i32* %y, i80* %y_10 + +define void @test_in_array([1 x %struct]* %st, i64 %i, i64 %j, i64 %k, i64 %i1, i64 %j1, i64 %k1) { + %x = getelementptr [1 x %struct]* %st, i64 %i, i64 %i1, i32 0 + %y = getelementptr [1 x %struct]* %st, i64 %j, i64 %j1, i32 1 + %z = getelementptr [1 x %struct]* %st, i64 %k, i64 %k1, i32 2 + %y_12 = bitcast i32* %y to %struct* + %y_10 = bitcast i32* %y to i80* + %y_8 = bitcast i32* %y to i64* + ret void +} + +; CHECK-LABEL: test_same_underlying_object_same_indices + +; CHECK-DAG: NoAlias: i32* %x, i32* %x2 +; CHECK-DAG: NoAlias: i32* %y, i32* %y2 +; CHECK-DAG: NoAlias: i32* %z, i32* %z2 + +; CHECK-DAG: PartialAlias: i32* %x, i32* %y2 +; CHECK-DAG: PartialAlias: i32* %x, i32* %z2 + +; CHECK-DAG: PartialAlias: i32* %x2, i32* %y +; CHECK-DAG: PartialAlias: i32* %y, i32* %z2 + +; CHECK-DAG: PartialAlias: i32* %x2, i32* %z +; CHECK-DAG: PartialAlias: i32* %y2, i32* %z + +define void @test_same_underlying_object_same_indices(%struct* %st, i64 %i, i64 %j, i64 %k) { + %st2 = getelementptr %struct* %st, i32 10 + %x2 = getelementptr %struct* %st2, i64 %i, i32 0 + %y2 = getelementptr %struct* %st2, i64 %j, i32 1 + %z2 = getelementptr %struct* %st2, i64 %k, i32 2 + %x = getelementptr %struct* %st, i64 %i, i32 0 + %y = getelementptr %struct* %st, i64 %j, i32 1 + %z = getelementptr %struct* %st, i64 %k, i32 2 + ret void +} + +; CHECK-LABEL: test_same_underlying_object_different_indices + +; CHECK-DAG: PartialAlias: i32* %x, i32* %x2 +; CHECK-DAG: PartialAlias: i32* %y, i32* %y2 +; CHECK-DAG: PartialAlias: i32* %z, i32* %z2 + +; CHECK-DAG: PartialAlias: i32* %x, i32* %y2 +; CHECK-DAG: PartialAlias: i32* %x, i32* %z2 + +; CHECK-DAG: PartialAlias: i32* %x2, i32* %y +; CHECK-DAG: PartialAlias: i32* %y, i32* %z2 + +; CHECK-DAG: PartialAlias: i32* %x2, i32* %z +; CHECK-DAG: PartialAlias: i32* %y2, i32* %z + +define void @test_same_underlying_object_different_indices(%struct* %st, i64 %i1, i64 %j1, i64 %k1, i64 %i2, i64 %k2, i64 %j2) { + %st2 = getelementptr %struct* %st, i32 10 + %x2 = getelementptr %struct* %st2, i64 %i2, i32 0 + %y2 = getelementptr %struct* %st2, i64 %j2, i32 1 + %z2 = getelementptr %struct* %st2, i64 %k2, i32 2 + %x = getelementptr %struct* %st, i64 %i1, i32 0 + %y = getelementptr %struct* %st, i64 %j1, i32 1 + %z = getelementptr %struct* %st, i64 %k1, i32 2 + ret void +} + + +%struct2 = type { [1 x { i32, i32 }], [2 x { i32 }] } + +; CHECK-LABEL: test_struct_in_array +; CHECK-DAG: MustAlias: i32* %x, i32* %y +define void @test_struct_in_array(%struct2* %st, i64 %i, i64 %j, i64 %k) { + %x = getelementptr %struct2* %st, i32 0, i32 1, i32 1, i32 0 + %y = getelementptr %struct2* %st, i32 0, i32 0, i32 1, i32 1 + ret void +}