This is an archive of the discontinued LLVM Phabricator instance.

Differential D74189

GlobalISel: Fix narrowing of G_CTPOP
ClosedPublic

Authored by arsenm on Feb 6 2020, 7:41 PM.

Details

Reviewers
aemerson
aditya_nandakumar
paquette
Petar.Avramovic
Summary

The result type is separate from the source type. Tests will be
included in a future AMDGPU patch which uses this from
RegBankSelect/applyMappingImpl.

Diff Detail

Revision Contents

PathSize
llvm/
lib/
CodeGen/
GlobalISel/
9 lines
Target/
Mips/
1 line

Diff 243069

llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp

Show First 20 Lines • Show All 4,034 Lines • ▼ Show 20 Lines
} }
LegalizerHelper::LegalizeResult LegalizerHelper::LegalizeResult
LegalizerHelper::narrowScalarCTPOP(MachineInstr &MI, unsigned TypeIdx, LegalizerHelper::narrowScalarCTPOP(MachineInstr &MI, unsigned TypeIdx,
LLT NarrowTy) { LLT NarrowTy) {
if (TypeIdx != 1) if (TypeIdx != 1)
return UnableToLegalize; return UnableToLegalize;
Register DstReg = MI.getOperand(0).getReg();
LLT DstTy = MRI.getType(DstReg);
LLT SrcTy = MRI.getType(MI.getOperand(1).getReg()); LLT SrcTy = MRI.getType(MI.getOperand(1).getReg());
unsigned NarrowSize = NarrowTy.getSizeInBits(); unsigned NarrowSize = NarrowTy.getSizeInBits();
if (SrcTy.isScalar() && SrcTy.getSizeInBits() == 2 * NarrowSize) { if (SrcTy.isScalar() && SrcTy.getSizeInBits() == 2 * NarrowSize) {
auto UnmergeSrc = MIRBuilder.buildUnmerge(NarrowTy, MI.getOperand(1)); auto UnmergeSrc = MIRBuilder.buildUnmerge(NarrowTy, MI.getOperand(1));
auto LoCTPOP = MIRBuilder.buildCTPOP(NarrowTy, UnmergeSrc.getReg(0)); auto LoCTPOP = MIRBuilder.buildCTPOP(DstTy, UnmergeSrc.getReg(0));
auto HiCTPOP = MIRBuilder.buildCTPOP(NarrowTy, UnmergeSrc.getReg(1)); auto HiCTPOP = MIRBuilder.buildCTPOP(DstTy, UnmergeSrc.getReg(1));
auto Out = MIRBuilder.buildAdd(NarrowTy, HiCTPOP, LoCTPOP); MIRBuilder.buildAdd(DstReg, HiCTPOP, LoCTPOP);
MIRBuilder.buildZExt(MI.getOperand(0), Out);
MI.eraseFromParent(); MI.eraseFromParent();
return Legalized; return Legalized;
} }
return UnableToLegalize; return UnableToLegalize;
} }
▲ Show 20 Lines • Show All 894 Lines • Show Last 20 Lines

llvm/lib/Target/Mips/MipsLegalizerInfo.cpp

Show First 20 Lines • Show All 210 Lines • ▼ Show 20 LinesMipsLegalizerInfo::MipsLegalizerInfo(const MipsSubtarget &ST) {
getActionDefinitionsBuilder(G_CTTZ) getActionDefinitionsBuilder(G_CTTZ)
.lowerFor({{s32, s32}}) .lowerFor({{s32, s32}})
.maxScalar(1, s32); .maxScalar(1, s32);
getActionDefinitionsBuilder(G_CTTZ_ZERO_UNDEF) getActionDefinitionsBuilder(G_CTTZ_ZERO_UNDEF)
.lowerFor({{s32, s32}, {s64, s64}}); .lowerFor({{s32, s32}, {s64, s64}});
getActionDefinitionsBuilder(G_CTPOP) getActionDefinitionsBuilder(G_CTPOP)
.lowerFor({{s32, s32}}) .lowerFor({{s32, s32}})
.clampScalar(0, s32, s32)
.clampScalar(1, s32, s32); .clampScalar(1, s32, s32);
// FP instructions // FP instructions
getActionDefinitionsBuilder(G_FCONSTANT) getActionDefinitionsBuilder(G_FCONSTANT)
.legalFor({s32, s64}); .legalFor({s32, s64});
getActionDefinitionsBuilder({G_FADD, G_FSUB, G_FMUL, G_FDIV, G_FABS, G_FSQRT}) getActionDefinitionsBuilder({G_FADD, G_FSUB, G_FMUL, G_FDIV, G_FABS, G_FSQRT})
.legalIf([=, &ST](const LegalityQuery &Query) { .legalIf([=, &ST](const LegalityQuery &Query) {
▲ Show 20 Lines • Show All 256 Lines • Show Last 20 Lines