Page MenuHomePhabricator

Fix a bug in vector load legalization
ClosedPublic

Authored by mkuper on Feb 4 2015, 1:30 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

mkuper updated this revision to Diff 19305.Feb 4 2015, 1:30 AM
mkuper retitled this revision from to Fix a bug in vector load legalization.
mkuper updated this object.
mkuper edited the test plan for this revision. (Show Details)
mkuper added a reviewer: hliao.
mkuper added a subscriber: Unknown Object (MLST).
hliao edited edge metadata.Feb 4 2015, 9:05 AM

LGTM

hliao added a comment.Feb 4 2015, 9:09 AM

Sorry, I misread the code. Won't that Offset should be BitOffset?

mkuper added a comment.Feb 4 2015, 9:27 AM

Ohhh, I see.
Thanks, Michael, will fix.

mkuper updated this revision to Diff 19337.Feb 4 2015, 10:39 AM
mkuper edited edge metadata.

Michael, how does this look?

hliao added a comment.Feb 4 2015, 10:40 AM

LGTM this time. Thanks for fixing that typo.

This revision was automatically updated to reflect the committed changes.