Page MenuHomePhabricator

Remove a gross usage of environment variables in MachineVerifier, replacing it with support for setting the -verify-machineinstrs flag via an environment variable in LIT.
ClosedPublic

Authored by resistor on Feb 3 2015, 10:32 AM.

Details

Summary

This preserves the handy functionality of force-enabling the MachineVerifier, without the need to embed usage of environment variables in LLVM client applications.

Diff Detail

Repository
rL LLVM

Event Timeline

resistor updated this revision to Diff 19246.Feb 3 2015, 10:32 AM
resistor retitled this revision from to Remove a gross usage of environment variables in MachineVerifier, replacing it with support for setting the -verify-machineinstrs flag via an environment variable in LIT..
resistor updated this object.
resistor edited the test plan for this revision. (Show Details)
resistor added reviewers: chandlerc, mehdi_amini.
resistor set the repository for this revision to rL LLVM.
resistor added a subscriber: Unknown Object (MLST).
chandlerc accepted this revision.Feb 3 2015, 12:45 PM
chandlerc edited edge metadata.

This looks great. Minor nit below, but submit whenever.

lib/CodeGen/MachineVerifier.cpp
66

From the other review, make this a reference? (Maybe that doesn't work with some other constructor.

This revision is now accepted and ready to land.Feb 3 2015, 12:45 PM
resistor closed this revision.Feb 3 2015, 4:04 PM

r228075