diff --git a/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp b/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp --- a/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp +++ b/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp @@ -265,37 +265,34 @@ return false; unsigned Opc = LdSt.getOpcode(); - const MachineOperand *BaseOp; + const MachineOperand *BaseOp, *OffsetOp; if (isDS(LdSt)) { - const MachineOperand *OffsetImm = - getNamedOperand(LdSt, AMDGPU::OpName::offset); - if (OffsetImm) { + BaseOp = getNamedOperand(LdSt, AMDGPU::OpName::addr); + OffsetOp = getNamedOperand(LdSt, AMDGPU::OpName::offset); + if (OffsetOp) { // Normal, single offset LDS instruction. - BaseOp = getNamedOperand(LdSt, AMDGPU::OpName::addr); - // TODO: ds_consume/ds_append use M0 for the base address. Is it safe to - // report that here? - if (!BaseOp || !BaseOp->isReg()) + if (!BaseOp) { + // DS_CONSUME/DS_APPEND use M0 for the base address. + // TODO: find the implicit use operand for M0 and use that as BaseOp? return false; - + } BaseOps.push_back(BaseOp); - Offset = OffsetImm->getImm(); - - return true; - } - - // The 2 offset instructions use offset0 and offset1 instead. We can treat - // these as a load with a single offset if the 2 offsets are consecutive. We - // will use this for some partially aligned loads. - const MachineOperand *Offset0Imm = - getNamedOperand(LdSt, AMDGPU::OpName::offset0); - const MachineOperand *Offset1Imm = - getNamedOperand(LdSt, AMDGPU::OpName::offset1); - - uint8_t Offset0 = Offset0Imm->getImm(); - uint8_t Offset1 = Offset1Imm->getImm(); + Offset = OffsetOp->getImm(); + } else { + // The 2 offset instructions use offset0 and offset1 instead. We can treat + // these as a load with a single offset if the 2 offsets are consecutive. + // We will use this for some partially aligned loads. + const MachineOperand *Offset0Op = + getNamedOperand(LdSt, AMDGPU::OpName::offset0); + const MachineOperand *Offset1Op = + getNamedOperand(LdSt, AMDGPU::OpName::offset1); + + unsigned Offset0 = Offset0Op->getImm(); + unsigned Offset1 = Offset1Op->getImm(); + if (Offset0 + 1 != Offset1) + return false; - if (Offset1 > Offset0 && Offset1 - Offset0 == 1) { // Each of these offsets is in element sized units, so we need to convert // to bytes of the individual reads. @@ -311,17 +308,10 @@ if (isStride64(Opc)) EltSize *= 64; - BaseOp = getNamedOperand(LdSt, AMDGPU::OpName::addr); - if (!BaseOp->isReg()) - return false; - BaseOps.push_back(BaseOp); Offset = EltSize * Offset0; - - return true; } - - return false; + return true; } if (isMUBUF(LdSt) || isMTBUF(LdSt)) { @@ -365,18 +355,12 @@ } if (isSMRD(LdSt)) { - const MachineOperand *OffsetImm = - getNamedOperand(LdSt, AMDGPU::OpName::offset); - if (!OffsetImm) - return false; - - const MachineOperand *SBaseReg = getNamedOperand(LdSt, AMDGPU::OpName::sbase); - BaseOp = SBaseReg; - Offset = OffsetImm->getImm(); - if (!BaseOp->isReg()) + BaseOp = getNamedOperand(LdSt, AMDGPU::OpName::sbase); + if (!BaseOp) // e.g. S_MEMTIME return false; - BaseOps.push_back(BaseOp); + OffsetOp = getNamedOperand(LdSt, AMDGPU::OpName::offset); + Offset = OffsetOp ? OffsetOp->getImm() : 0; return true; }