Index: clang/lib/StaticAnalyzer/Checkers/BoolAssignmentChecker.cpp =================================================================== --- clang/lib/StaticAnalyzer/Checkers/BoolAssignmentChecker.cpp +++ clang/lib/StaticAnalyzer/Checkers/BoolAssignmentChecker.cpp @@ -70,8 +70,8 @@ // Get the value of the right-hand side. We only care about values // that are defined (UnknownVals and UndefinedVals are handled by other // checkers). - Optional DV = val.getAs(); - if (!DV) + Optional NV = val.getAs(); + if (!NV) return; // Check if the assigned value meets our criteria for correctness. It must @@ -79,78 +79,17 @@ // the value is possibly < 0 (for a negative value) or greater than 1. ProgramStateRef state = C.getState(); SValBuilder &svalBuilder = C.getSValBuilder(); + BasicValueFactory &BVF = svalBuilder.getBasicValueFactory(); ConstraintManager &CM = C.getConstraintManager(); - // First, ensure that the value is >= 0. - DefinedSVal zeroVal = svalBuilder.makeIntVal(0, valTy); - SVal greaterThanOrEqualToZeroVal = - svalBuilder.evalBinOp(state, BO_GE, *DV, zeroVal, - svalBuilder.getConditionType()); + llvm::APSInt Zero = BVF.getValue(0, valTy); + llvm::APSInt One = BVF.getValue(1, valTy); - Optional greaterThanEqualToZero = - greaterThanOrEqualToZeroVal.getAs(); + ProgramStateRef StIn, StOut; + std::tie(StIn, StOut) = CM.assumeInclusiveRangeDual(state, *NV, Zero, One); - if (!greaterThanEqualToZero) { - // The SValBuilder cannot construct a valid SVal for this condition. - // This means we cannot properly reason about it. - return; - } - - ProgramStateRef stateLT, stateGE; - std::tie(stateGE, stateLT) = CM.assumeDual(state, *greaterThanEqualToZero); - - // Is it possible for the value to be less than zero? - if (stateLT) { - // It is possible for the value to be less than zero. We only - // want to emit a warning, however, if that value is fully constrained. - // If it it possible for the value to be >= 0, then essentially the - // value is underconstrained and there is nothing left to be done. - if (!stateGE) - emitReport(stateLT, C); - - // In either case, we are done. - return; - } - - // If we reach here, it must be the case that the value is constrained - // to only be >= 0. - assert(stateGE == state); - - // At this point we know that the value is >= 0. - // Now check to ensure that the value is <= 1. - DefinedSVal OneVal = svalBuilder.makeIntVal(1, valTy); - SVal lessThanEqToOneVal = - svalBuilder.evalBinOp(state, BO_LE, *DV, OneVal, - svalBuilder.getConditionType()); - - Optional lessThanEqToOne = - lessThanEqToOneVal.getAs(); - - if (!lessThanEqToOne) { - // The SValBuilder cannot construct a valid SVal for this condition. - // This means we cannot properly reason about it. - return; - } - - ProgramStateRef stateGT, stateLE; - std::tie(stateLE, stateGT) = CM.assumeDual(state, *lessThanEqToOne); - - // Is it possible for the value to be greater than one? - if (stateGT) { - // It is possible for the value to be greater than one. We only - // want to emit a warning, however, if that value is fully constrained. - // If it is possible for the value to be <= 1, then essentially the - // value is underconstrained and there is nothing left to be done. - if (!stateLE) - emitReport(stateGT, C); - - // In either case, we are done. - return; - } - - // If we reach here, it must be the case that the value is constrained - // to only be <= 1. - assert(stateLE == state); + if (StOut) + emitReport(StOut, C); } void ento::registerBoolAssignmentChecker(CheckerManager &mgr) { Index: clang/test/Analysis/bool-assignment.c =================================================================== --- clang/test/Analysis/bool-assignment.c +++ clang/test/Analysis/bool-assignment.c @@ -43,11 +43,7 @@ return; } if (y > 200 && y < 250) { -#ifdef ANALYZER_CM_Z3 BOOL x = y; // expected-warning {{Assignment of a non-Boolean value}} -#else - BOOL x = y; // no-warning -#endif return; } if (y >= 127 && y < 150) { Index: clang/test/Analysis/dead-stores.m =================================================================== --- clang/test/Analysis/dead-stores.m +++ clang/test/Analysis/dead-stores.m @@ -54,7 +54,7 @@ - (void) bar_rbar8527823 { @synchronized(self) { - BOOL isExec = baz_rdar8527823(); // no-warning + BOOL isExec = baz_rdar8527823(); // expected-warning {{Assignment of a non-Boolean value}} if (isExec) foo_rdar8527823(); } } Index: clang/test/Analysis/misc-ps-eager-assume.m =================================================================== --- clang/test/Analysis/misc-ps-eager-assume.m +++ clang/test/Analysis/misc-ps-eager-assume.m @@ -1,5 +1,4 @@ // RUN: %clang_analyze_cc1 -analyzer-checker=core,alpha.core -analyzer-store=region -verify -fblocks %s -// expected-no-diagnostics // Delta-reduced header stuff (needed for test cases). typedef signed char BOOL; @@ -56,7 +55,7 @@ void handle_symbolic_cast_in_condition(void) { NSAutoreleasePool* pool = [[NSAutoreleasePool alloc] init]; - BOOL needsAnArray = [@"aString" isEqualToString:@"anotherString"]; + BOOL needsAnArray = [@"aString" isEqualToString:@"anotherString"]; // expected-warning {{Assignment of a non-Boolean value}} NSMutableArray* array = needsAnArray ? [[NSMutableArray alloc] init] : 0; if(needsAnArray) [array release];