Page MenuHomePhabricator

Fix makeLibCall argument (signed) in SoftenFloatRes_XINT_TO_FP function
ClosedPublic

Authored by spetrovic on Jan 30 2015, 4:58 AM.

Details

Summary

The isSigned argument of makeLibCall function was hard-coded to false (unsigned). This caused zero extension on MIPS64 soft float.
As the result SingleSource/Benchmarks/Stanford/FloatMM test and SingleSource/UnitTests/2005-07-17-INT-To-FP test failed.
The solution was to use the proper argument.

Diff Detail

Repository
rL LLVM

Event Timeline

spetrovic updated this revision to Diff 19031.Jan 30 2015, 4:58 AM
spetrovic retitled this revision from to Fix makeLibCall argument (signed) in SoftenFloatRes_XINT_TO_FP function.
spetrovic updated this object.
spetrovic edited the test plan for this revision. (Show Details)
spetrovic added reviewers: t.p.northover, petarj.
spetrovic set the repository for this revision to rL LLVM.
spetrovic added a subscriber: Unknown Object (MLST).
This comment was removed by spetrovic.
petarj edited edge metadata.Feb 5 2015, 9:12 AM

LGTM, though it would be good to know if this affects any other architecture.

Any more comments? Is this OK to commit now?

This revision was automatically updated to reflect the committed changes.