diff --git a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp --- a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp +++ b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp @@ -49,7 +49,14 @@ auto *sequentialType = cast(llvmType); auto elementType = sequentialType->getElementType(); uint64_t numElements = sequentialType->getNumElements(); - auto *child = getLLVMConstant(elementType, splatAttr.getSplatValue(), loc); + // Splat value is a scalar. Extract it only if the element type is not + // another sequence type. The recursion terminates because each step removes + // one outer sequential type. + llvm::Constant *child = getLLVMConstant( + elementType, + isa(elementType) ? splatAttr + : splatAttr.getSplatValue(), + loc); if (llvmType->isVectorTy()) return llvm::ConstantVector::getSplat(numElements, child); if (llvmType->isArrayTy()) { diff --git a/mlir/test/Target/llvmir.mlir b/mlir/test/Target/llvmir.mlir --- a/mlir/test/Target/llvmir.mlir +++ b/mlir/test/Target/llvmir.mlir @@ -804,6 +804,34 @@ llvm.return %1 : !llvm<"<4 x float>"> } +// CHECK-LABEL: @vector_splat_1d +llvm.func @vector_splat_1d() -> !llvm<"<4 x float>"> { + // CHECK: ret <4 x float> zeroinitializer + %0 = llvm.mlir.constant(dense<0.000000e+00> : vector<4xf32>) : !llvm<"<4 x float>"> + llvm.return %0 : !llvm<"<4 x float>"> +} + +// CHECK-LABEL: @vector_splat_2d +llvm.func @vector_splat_2d() -> !llvm<"[4 x <16 x float>]"> { + // CHECK: ret [4 x <16 x float>] zeroinitializer + %0 = llvm.mlir.constant(dense<0.000000e+00> : vector<4x16xf32>) : !llvm<"[4 x <16 x float>]"> + llvm.return %0 : !llvm<"[4 x <16 x float>]"> +} + +// CHECK-LABEL: @vector_splat_3d +llvm.func @vector_splat_3d() -> !llvm<"[4 x [16 x <4 x float>]]"> { + // CHECK: ret [4 x [16 x <4 x float>]] zeroinitializer + %0 = llvm.mlir.constant(dense<0.000000e+00> : vector<4x16x4xf32>) : !llvm<"[4 x [16 x <4 x float>]]"> + llvm.return %0 : !llvm<"[4 x [16 x <4 x float>]]"> +} + +// CHECK-LABEL: @vector_splat_nonzero +llvm.func @vector_splat_nonzero() -> !llvm<"<4 x float>"> { + // CHECK: ret <4 x float> + %0 = llvm.mlir.constant(dense<1.000000e+00> : vector<4xf32>) : !llvm<"<4 x float>"> + llvm.return %0 : !llvm<"<4 x float>"> +} + // CHECK-LABEL: @ops llvm.func @ops(%arg0: !llvm.float, %arg1: !llvm.float, %arg2: !llvm.i32, %arg3: !llvm.i32) -> !llvm<"{ float, i32 }"> { // CHECK-NEXT: fsub float %0, %1