Page MenuHomePhabricator

Enable testing ASAN on AArch64
ClosedPublic

Authored by christophe.lyon on Jan 29 2015, 2:27 AM.

Details

Reviewers
kcc
rengolin
Summary

This patch is related to http://reviews.llvm.org/D7243, and enables testing ASAN on AArch64.

When both patches are applied, I can see 2 failures in the testsuite:
Asan-aarch64-inline-Test/AddressSanitizer.BuiltinLongJmpTest
Asan-aarch64-with-calls-Test/AddressSanitizer.BuiltinLongJmpTest

I have tried to debug them, and I am not wondering if these tests should be skipped as on ARM, PowerPC.
As a matter of fact, I have extracted a sample program which does run when compiled with GCC, but loops & crashes when compiled with clang: maybe __builtin_longjmp is broken on AArch64 in Clang/LLVM?

Thanks.

Diff Detail

Event Timeline

christophe.lyon retitled this revision from to Enable testing ASAN on AArch64.
christophe.lyon updated this object.
christophe.lyon edited the test plan for this revision. (Show Details)
christophe.lyon added reviewers: rengolin, kcc.
christophe.lyon added a subscriber: Unknown Object (MLST).
rengolin edited edge metadata.Jan 29 2015, 4:30 AM

Hi Christophe,

We don't care much for longjump on ARM/AArhc64, that's why I made them fail on ARM. I think the same reasoning apply to AArch64, so I'd be in favour of setting them XFAIL on aarch64, too.

However, I'd like to see that patch land in before this one, so we don't break the bots.

cheers,
--renato

Here is an update, with the offending longjmp test disabled on aarch64.

rengolin accepted this revision.Feb 3 2015, 3:28 AM
rengolin edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 3:28 AM
rengolin closed this revision.Feb 3 2015, 3:28 AM

Committed in r227966.