Index: llvm/docs/DeveloperPolicy.rst =================================================================== --- llvm/docs/DeveloperPolicy.rst +++ llvm/docs/DeveloperPolicy.rst @@ -89,7 +89,9 @@ patches may not apply correctly if the underlying code changes between the time the patch was created and the time it is applied. -#. Patches should be made with ``git format-patch``, or similar. If you use a +#. Patches should be made with ``git format-patch``, or similar (see special + commands for `Requesting Phabricator review via the web interface + `_ ). If you use a different tool, make sure it uses the ``diff -u`` format and that it doesn't contain clutter which makes it hard to read. Index: llvm/docs/GettingStarted.rst =================================================================== --- llvm/docs/GettingStarted.rst +++ llvm/docs/GettingStarted.rst @@ -450,8 +450,8 @@ You'll generally want to make sure your branch has a single commit, corresponding to the review you wish to send, up-to-date with the upstream ``origin/master`` branch, and doesn't contain merges. Once you have that, you -can use ``git show`` or ``git format-patch`` to output the diff, and attach it -to a Phabricator review (or to an email message). +can start `a Phabricator review `_ (or use ``git show`` or +``git format-patch`` to output the diff, and attach it to an email message). However, using the "Arcanist" tool is often easier. After `installing arcanist`_, you can upload the latest commit using: Index: llvm/docs/Phabricator.rst =================================================================== --- llvm/docs/Phabricator.rst +++ llvm/docs/Phabricator.rst @@ -59,7 +59,8 @@ to upload your patch): * ``git show HEAD -U999999 > mypatch.patch`` -* ``git format-patch -U999999 @{u}`` +* ``git diff -U999999 @{u} > mypatch.patch`` +* ``git diff HEAD~1 -U999999 > mypatch.patch`` Before uploading your patch, please make sure it is formatted properly, as described in :ref:`How to Submit a Patch `.