Page MenuHomePhabricator

irgen: don't emit debug metadata for locals
ClosedPublic

Authored by axw on Jan 27 2015, 11:43 PM.

Details

Summary

The debug metadata we generate is wrong, and is
now causing build failures. This revision disables
the only llvm.dbg.declare calls we make.

(There is also a drive-by fix to CMakeLists.txt,
adding in a missing .go dependency.)

Fixes http://llvm.org/bugs/show_bug.cgi?id=22330

Diff Detail

Event Timeline

axw updated this revision to Diff 18878.Jan 27 2015, 11:43 PM
axw retitled this revision from to irgen: don't emit debug metadata for locals.
axw updated this object.
axw edited the test plan for this revision. (Show Details)
axw added a reviewer: pcc.
axw added a subscriber: Unknown Object (MLST).
axw updated this object.Jan 28 2015, 1:00 AM
pcc accepted this revision.Jan 28 2015, 10:41 AM
pcc edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jan 28 2015, 10:41 AM

(might be useful to include [llgo] or something similar in the subject line
in the future to help reviewers filter/prioritize appropriately - took me a
moment to realize this wasn't something I needed to worry about)

axw closed this revision.Jan 28 2015, 4:36 PM
axw added a comment.Jan 28 2015, 4:36 PM

(might be useful to include [llgo] or something similar in the subject line
in the future to help reviewers filter/prioritize appropriately - took me a
moment to realize this wasn't something I needed to worry about)

Will do, sorry for the noise.