diff --git a/lld/ELF/SyntheticSections.cpp b/lld/ELF/SyntheticSections.cpp --- a/lld/ELF/SyntheticSections.cpp +++ b/lld/ELF/SyntheticSections.cpp @@ -1437,14 +1437,13 @@ addSym(DT_FINI, b); } - bool hasVerNeed = SharedFile::vernauxNum != 0; - if (hasVerNeed || part.verDef) + if (part.verSym && part.verSym->isNeeded()) addInSec(DT_VERSYM, part.verSym); - if (part.verDef) { + if (part.verDef && part.verDef->isLive()) { addInSec(DT_VERDEF, part.verDef); addInt(DT_VERDEFNUM, getVerDefNum()); } - if (hasVerNeed) { + if (part.verNeed && part.verNeed->isNeeded()) { addInSec(DT_VERNEED, part.verNeed); unsigned needNum = 0; for (SharedFile *f : sharedFiles) @@ -2963,7 +2962,8 @@ } bool VersionTableSection::isNeeded() const { - return getPartition().verDef || getPartition().verNeed->isNeeded(); + return isLive() && + (getPartition().verDef || getPartition().verNeed->isNeeded()); } void addVerneed(Symbol *ss) { @@ -3051,7 +3051,7 @@ } template bool VersionNeedSection::isNeeded() const { - return SharedFile::vernauxNum != 0; + return isLive() && SharedFile::vernauxNum != 0; } void MergeSyntheticSection::addSection(MergeInputSection *ms) { diff --git a/lld/test/ELF/linkerscript/discard-gnu-version.s b/lld/test/ELF/linkerscript/discard-gnu-version.s new file mode 100644 --- /dev/null +++ b/lld/test/ELF/linkerscript/discard-gnu-version.s @@ -0,0 +1,47 @@ +# REQUIRES: x86 +# RUN: echo '.globl f; f:' | llvm-mc -filetype=obj -triple=x86_64 - -o %t1.o +# RUN: echo 'v1 { f; };' > %t1.ver +# RUN: ld.lld -shared --version-script %t1.ver %t1.o -o %t1.so + +# RUN: llvm-mc -filetype=obj -triple=x86_64 %s -o %t.o +# RUN: echo 'v1 { foo; };' > %t.ver +# RUN: ld.lld -shared --version-script %t.ver %t.o %t1.so -o %t.so +# RUN: llvm-readelf -S -d %t.so | FileCheck --check-prefixes=SYM,DEF,NEED %s + +# SYM: .gnu.version +# DEF: .gnu.version_d +# NEED: .gnu.version_r + +# SYM: (VERSYM) +# DEF: (VERDEF) +# DEF: (VERDEFNUM) +# NEED: (VERNEED) +# NEED: (VERNEEDNUM) + +## Discard all of .gnu.version* +# RUN: echo 'SECTIONS { /DISCARD/ : { *(.gnu.version*) } }' > %t.script +# RUN: ld.lld -shared --version-script %t.ver -T %t.script %t.o %t1.so -o %t.so +# RUN: llvm-readelf -S -d %t.so | FileCheck /dev/null \ +# RUN: --implicit-check-not='(VER' --implicit-check-not=.gnu.version + +## Discard .gnu.version +# RUN: echo 'SECTIONS { /DISCARD/ : { *(.gnu.version) } }' > %t.noversym.script +# RUN: ld.lld -shared --version-script %t.ver -T %t.noversym.script %t.o %t1.so -o %t.noversym.so +# RUN: llvm-readelf -S -d %t.noversym.so | FileCheck --check-prefixes=DEF,NEED %s \ +# RUN: --implicit-check-not='(VER' --implicit-check-not=.gnu.version + +## Discard .gnu.version_d +# RUN: echo 'SECTIONS { /DISCARD/ : { *(.gnu.version_d) } }' > %t.noverdef.script +# RUN: ld.lld -shared --version-script %t.ver -T %t.noverdef.script %t.o %t1.so -o %t.noverdef.so +# RUN: llvm-readelf -S -d %t.noverdef.so | FileCheck --check-prefixes=SYM,NEED %s \ +# RUN: --implicit-check-not='(VER' --implicit-check-not=.gnu.version + +## Discard .gnu.version_r +# RUN: echo 'SECTIONS { /DISCARD/ : { *(.gnu.version_r) } }' > %t.noverneed.script +# RUN: ld.lld -shared --version-script %t.ver -T %t.noverneed.script %t.o %t1.so -o %t.noverneed.so +# RUN: llvm-readelf -S -d %t.noverneed.so | FileCheck --check-prefixes=SYM,DEF %s \ +# RUN: --implicit-check-not='(VER' --implicit-check-not=.gnu.version + +.globl foo +foo: + call f@plt