[Analyzer] Fixes -Wrange-loop-analysis warnings

[Mordante]

Summary

This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall.

[aaron.ballman]

LGTM!

clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp

 
 void IteratorModeling::printState(raw_ostream &Out, ProgramStateRef State,
                                   const char *NL, const char *Sep) const {
 
   auto ContMap = State->get<ContainerMap>();
 
   if (!ContMap.isEmpty()) {
     Out << Sep << "Container Data :" << NL;
-    for (const auto Cont : ContMap) {
+    for (const auto &Cont : ContMap) {
       Cont.first->dumpToStream(Out);
       Out << " : [ ";
       const auto CData = Cont.second;
       if (CData.getBegin())
         CData.getBegin()->dumpToStream(Out);
       else
         Out << "<Unknown>";
       Out << " .. ";
       if (CData.getEnd())
         CData.getEnd()->dumpToStream(Out);
       else
         Out << "<Unknown>";
       Out << " ]" << NL;
     }
   }
 
   auto SymbolMap = State->get<IteratorSymbolMap>();
   auto RegionMap = State->get<IteratorRegionMap>();
 
   if (!SymbolMap.isEmpty() || !RegionMap.isEmpty()) {
     Out << Sep << "Iterator Positions :" << NL;
-    for (const auto Sym : SymbolMap) {
+    for (const auto &Sym : SymbolMap) {
       Sym.first->dumpToStream(Out);
       Out << " : ";
       const auto Pos = Sym.second;
       Out << (Pos.isValid() ? "Valid" : "Invalid") << " ; Container == ";
       Pos.getContainer()->dumpToStream(Out);
       Out<<" ; Offset == ";
       Pos.getOffset()->dumpToStream(Out);
     }
 
-    for (const auto Reg : RegionMap) {
+    for (const auto &Reg : RegionMap) {
       Reg.first->dumpToStream(Out);
       Out << " : ";
       const auto Pos = Reg.second;
       Out << (Pos.isValid() ? "Valid" : "Invalid") << " ; Container == ";
       Pos.getContainer()->dumpToStream(Out);
       Out<<" ; Offset == ";
       Pos.getOffset()->dumpToStream(Out);
     }

clang/lib/StaticAnalyzer/Checkers/MoveChecker.cpp

void MoveChecker::checkPreCall(const CallEvent &Call, CheckerContext &C) const {
 
   modelUse(State, ThisRegion, RD, MK_FunCall, C);
 }
 
 void MoveChecker::checkDeadSymbols(SymbolReaper &SymReaper,
                                    CheckerContext &C) const {
   ProgramStateRef State = C.getState();
   TrackedRegionMapTy TrackedRegions = State->get<TrackedRegionMap>();
-  for (TrackedRegionMapTy::value_type E : TrackedRegions) {
+  for (const auto &E : TrackedRegions) {
     const MemRegion *Region = E.first;
     bool IsRegDead = !SymReaper.isLiveRegion(Region);
 
     // Remove the dead regions from the region map.
     if (IsRegDead) {
       State = State->remove<TrackedRegionMap>(Region);
     }
   }

clang/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp

void CheckerRegistry::printCheckerOptionList(raw_ostream &Out) const {
 
   auto Print = [] (llvm::raw_ostream &Out, StringRef FullOption, StringRef Desc) {
     AnalyzerOptions::printFormattedEntry(Out, {FullOption, Desc},
                                          /*InitialPad*/ 2,
                                          /*EntryWidth*/ 50,
                                          /*MinLineWidth*/ 90);
     Out << "\n\n";
   };
-  for (const std::pair<StringRef, const CmdLineOption &> &Entry : OptionMap) {
+  for (const std::pair<const StringRef, const CmdLineOption &> &Entry :
+       OptionMap) {
     const CmdLineOption &Option = Entry.second;
     std::string FullOption = (Entry.first + ":" + Option.OptionName).str();
 
     std::string Desc =
         ("(" + Option.OptionType + ") " + Option.Description + " (default: " +
          (Option.DefaultValStr.empty() ? "\"\"" : Option.DefaultValStr) + ")")
             .str();