This is an archive of the discontinued LLVM Phabricator instance.

[clang] [ast] CXXRecordDecl::getVisibleConversionFunctions() could be const
ClosedPublic

Authored by whisperity on Dec 22 2019, 5:01 AM.

Details

Summary

The function and its called static helpers don't modify the received CXXRecordDecl arguments at all as the method result is put into an output parameter. Thus, they can be const which allows for neatly grabbing the conversion methods in a context where we only have a const ASTUnit at hand.

Diff Detail

Event Timeline

whisperity created this revision.Dec 22 2019, 5:01 AM
rjmccall accepted this revision.Dec 22 2019, 1:17 PM

LGTM.

This revision is now accepted and ready to land.Dec 22 2019, 1:17 PM
This revision was automatically updated to reflect the committed changes.