Index: clang/lib/CodeGen/CodeGenFunction.cpp =================================================================== --- clang/lib/CodeGen/CodeGenFunction.cpp +++ clang/lib/CodeGen/CodeGenFunction.cpp @@ -966,7 +966,7 @@ if (!CGM.getCodeGenOpts().CallFEntry) CGM.getDiags().Report(diag::err_opt_not_valid_without_opt) << "-mnop-mcount" << "-mfentry"; - Fn->addFnAttr("mnop-mcount", "true"); + Fn->addFnAttr("mnop-mcount"); } } } Index: clang/test/CodeGen/mnop-mcount.c =================================================================== --- clang/test/CodeGen/mnop-mcount.c +++ clang/test/CodeGen/mnop-mcount.c @@ -17,9 +17,9 @@ return foo(); } -//CHECK: attributes #0 = { {{.*}}"mnop-mcount"="true"{{.*}} } +//CHECK: attributes #0 = { {{.*}}"mnop-mcount"{{.*}} } //CHECK: attributes #1 = { {{.*}} } -//CHECK-NOT: attributes #1 = { {{.*}}"mnop-mcount"="true"{{.*}} } +//CHECK-NOT: attributes #1 = { {{.*}}"mnop-mcount"{{.*}} } //NOMFENTRY: error: option '-mnop-mcount' cannot be specified without '-mfentry' //NOPG-NOT: attributes #0 = { {{.*}}"mnop-mcount"{{.*}} } //NOPG-NOT: attributes #1 = { {{.*}}"mnop-mcount"{{.*}} } Index: llvm/lib/Target/SystemZ/SystemZAsmPrinter.cpp =================================================================== --- llvm/lib/Target/SystemZ/SystemZAsmPrinter.cpp +++ llvm/lib/Target/SystemZ/SystemZAsmPrinter.cpp @@ -553,8 +553,7 @@ void SystemZAsmPrinter::LowerFENTRY_CALL(const MachineInstr &MI, SystemZMCInstLower &Lower) { MCContext &Ctx = MF->getContext(); - if (MF->getFunction().getFnAttribute("mnop-mcount") - .getValueAsString() == "true") { + if (MF->getFunction().hasFnAttribute("mnop-mcount")) { EmitNop(Ctx, *OutStreamer, 6, getSubtargetInfo()); return; } Index: llvm/lib/Target/SystemZ/SystemZISelDAGToDAG.cpp =================================================================== --- llvm/lib/Target/SystemZ/SystemZISelDAGToDAG.cpp +++ llvm/lib/Target/SystemZ/SystemZISelDAGToDAG.cpp @@ -347,7 +347,7 @@ bool runOnMachineFunction(MachineFunction &MF) override { const Function &F = MF.getFunction(); - if (F.getFnAttribute("mnop-mcount").getValueAsString() == "true" && + if (F.hasFnAttribute("mnop-mcount") && F.getFnAttribute("fentry-call").getValueAsString() != "true") report_fatal_error("mnop-mcount only supported with fentry-call"); Index: llvm/test/CodeGen/SystemZ/mnop-mcount-01.ll =================================================================== --- llvm/test/CodeGen/SystemZ/mnop-mcount-01.ll +++ llvm/test/CodeGen/SystemZ/mnop-mcount-01.ll @@ -22,5 +22,5 @@ } attributes #0 = { "fentry-call"="true" } -attributes #1 = { "fentry-call"="true" "mnop-mcount"="true" } +attributes #1 = { "fentry-call"="true" "mnop-mcount" } Index: llvm/test/CodeGen/SystemZ/mnop-mcount-02.ll =================================================================== --- llvm/test/CodeGen/SystemZ/mnop-mcount-02.ll +++ llvm/test/CodeGen/SystemZ/mnop-mcount-02.ll @@ -7,5 +7,4 @@ ret void } -attributes #0 = { "instrument-function-entry-inlined"="mcount" "mnop-mcount"="true" } - +attributes #0 = { "instrument-function-entry-inlined"="mcount" "mnop-mcount" }