Page MenuHomePhabricator

Upgrade libc++'s test's CMakeLists.txt to be in sync with libc++abi's
AbandonedPublic

Authored by jroelofs on Jan 21 2015, 3:37 PM.

Details

Reviewers
danalbert

Diff Detail

Event Timeline

jroelofs updated this revision to Diff 18562.Jan 21 2015, 3:37 PM
jroelofs retitled this revision from to Upgrade libc++'s test's CMakeLists.txt to be in sync with libc++abi's.
jroelofs updated this object.
jroelofs edited the test plan for this revision. (Show Details)
jroelofs added a reviewer: danalbert.
jroelofs added a subscriber: Unknown Object (MLST).
danalbert added inline comments.Jan 21 2015, 3:42 PM
CMakeLists.txt
17

We probably want to keep the configuration for the default args (and the assignment to LLVM_LIT_ARGS).

jroelofs updated this revision to Diff 18640.Jan 22 2015, 3:17 PM

Address @danalbert's comment about the default lit args.

danalbert added inline comments.Jan 22 2015, 3:47 PM
CMakeLists.txt
51

As I read the implementation of add_lit_testsuite this will actually pass the args twice (LLVM_LIT_ARGS is passed implicitly, thank you, global scope!).

jroelofs updated this revision to Diff 18675.Jan 23 2015, 6:59 AM

Rebase. Address @danalbert's comment.

I don't have cmake 3.2, so I can't check that the thing added in the rebase still works :(

jroelofs abandoned this revision.Jul 14 2015, 4:14 PM