diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp --- a/llvm/lib/Target/X86/X86ISelLowering.cpp +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp @@ -1974,7 +1974,7 @@ bool X86TargetLowering::useStackGuardXorFP() const { // Currently only MSVC CRTs XOR the frame pointer into the stack guard value. - return Subtarget.getTargetTriple().isOSMSVCRT(); + return Subtarget.getTargetTriple().isOSMSVCRT() && !Subtarget.isTargetMachO(); } SDValue X86TargetLowering::emitStackGuardXorFP(SelectionDAG &DAG, SDValue Val, diff --git a/llvm/test/CodeGen/X86/stack-protector-strong-macho-win32-xor.ll b/llvm/test/CodeGen/X86/stack-protector-strong-macho-win32-xor.ll new file mode 100644 --- /dev/null +++ b/llvm/test/CodeGen/X86/stack-protector-strong-macho-win32-xor.ll @@ -0,0 +1,53 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=x86_64-pc-windows-macho < %s -o - | FileCheck %s +target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" +target triple = "x86_64-pc-windows-macho" + +; This test checks that on Win32 MachO targets we don't xor the cookie with rbp before checking. + +@.str = private unnamed_addr constant [15 x i8] c"Hello World!\0A \00", align 1 +define dso_local i32 @main(i32 %argc, i8** %argv, ...) #0 { +; CHECK-LABEL: main: +; CHECK: ## %bb.0: ## %entry +; CHECK-NEXT: pushq %rbp +; CHECK-NEXT: movq %rsp, %rbp +; CHECK-NEXT: subq $320, %rsp ## imm = 0x140 +; CHECK-NEXT: movq ___security_cookie@{{.*}}(%rip), %rax +; CHECK-NEXT: movq (%rax), %rax +; CHECK-NEXT: movq %rax, -8(%rbp) +; CHECK-NEXT: movl %ecx, -276(%rbp) +; CHECK-NEXT: movq %rdx, -288(%rbp) +; CHECK-NEXT: movslq -276(%rbp), %rax +; CHECK-NEXT: movb $1, -272(%rbp,%rax) +; CHECK-NEXT: leaq {{.*}}(%rip), %rcx +; CHECK-NEXT: callq _printf +; CHECK-NEXT: movq -8(%rbp), %rcx +; CHECK-NEXT: callq ___security_check_cookie +; CHECK-NEXT: xorl %eax, %eax +; CHECK-NEXT: addq $320, %rsp ## imm = 0x140 +; CHECK-NEXT: popq %rbp +; CHECK-NEXT: retq +entry: + %argc.addr = alloca i32, align 4 + %argv.addr = alloca i8**, align 8 + %Buffer = alloca [256 x i8], align 16 + store i32 %argc, i32* %argc.addr, align 4 + store i8** %argv, i8*** %argv.addr, align 8 + %0 = load i32, i32* %argc.addr, align 4 + %idxprom = sext i32 %0 to i64 + %arrayidx = getelementptr inbounds [256 x i8], [256 x i8]* %Buffer, i64 0, i64 %idxprom + store i8 1, i8* %arrayidx, align 1 + %call = call i32 (i8*, ...) @printf(i8* getelementptr inbounds ([15 x i8], [15 x i8]* @.str, i64 0, i64 0)) + ret i32 0 +} +declare dso_local i32 @printf(i8*, ...) #1 + +attributes #0 = { noinline nounwind optnone sspstrong "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" } +attributes #1 = { "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" } + +!llvm.module.flags = !{!0, !1} +!llvm.ident = !{!2} + +!0 = !{i32 1, !"wchar_size", i32 4} +!1 = !{i32 7, !"PIC Level", i32 2} +!2 = !{!"clang version 10.0.0"}