Page MenuHomePhabricator

[lldb/IRExecutionUnit] Stop searching based on demangled names
ClosedPublic

Authored by labath on Nov 26 2019, 8:49 AM.

Details

Summary

This was causing problems on linux, where we'd end up calling the
deleting destructor instead of a regular one (because they have the same
demangled name), making a lot of mischief in the process.

The only place where this was necessary (according to the test suite, at
least) was to call a base structor instead of a complete one, but this
is now handled in a more targeted fashion.

TestCallOverriddenMethod is now re-enabled as it now passes reliably.

Diff Detail

Event Timeline

labath created this revision.Nov 26 2019, 8:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 26 2019, 8:49 AM

Seems reasonable. @teemperor wdyt?

teemperor accepted this revision.Dec 3 2019, 4:25 AM

LGTM, thanks for fixing this!

This revision is now accepted and ready to land.Dec 3 2019, 4:25 AM
This revision was automatically updated to reflect the committed changes.