diff --git a/lld/ELF/LinkerScript.cpp b/lld/ELF/LinkerScript.cpp --- a/lld/ELF/LinkerScript.cpp +++ b/lld/ELF/LinkerScript.cpp @@ -442,7 +442,7 @@ } void LinkerScript::discard(InputSectionBase *s) { - if (s == in.shStrTab || s == mainPart->relaDyn || s == mainPart->relrDyn) + if (s == in.shStrTab || s == mainPart->relrDyn) error("discarding " + s->name + " section is not allowed"); // You can discard .hash and .gnu.hash sections by linker scripts. Since diff --git a/lld/test/ELF/linkerscript/discard-section-err.s b/lld/test/ELF/linkerscript/discard-section-err.s --- a/lld/test/ELF/linkerscript/discard-section-err.s +++ b/lld/test/ELF/linkerscript/discard-section-err.s @@ -20,8 +20,19 @@ # RUN: ld.lld -pie -o %t --script %t.script %t.o # RUN: echo "SECTIONS { /DISCARD/ : { *(.rela.dyn) } }" > %t.script -# RUN: not ld.lld -pie -o %t --script %t.script %t.o 2>&1 | \ -# RUN: FileCheck -check-prefix=RELADYN %s -# RELADYN: discarding .rela.dyn section is not allowed +# RUN: ld.lld -pie -o %t %t.o +# RUN: llvm-readobj -S %t | FileCheck --check-prefix=RELADYN %s +# RELADYN: Name: .rela.dyn +# RUN: ld.lld -pie -o %t --script %t.script %t.o +# RUN: llvm-readobj -S %t | FileCheck /dev/null --implicit-check-not='Name: .rela.dyn' + +# RUN: echo "SECTIONS { /DISCARD/ : { *(.relr.dyn) } }" > %t.script +# RUN: not ld.lld -pie --pack-dyn-relocs=relr -o %t --script %t.script %t.o 2>&1 | \ +# RUN: FileCheck -check-prefix=RELRDYN %s +# RELRDYN: discarding .relr.dyn section is not allowed -.comm foo,4,4 +.data +.align 8 +foo: +## Emits an R_X86_64_RELATIVE in -pie mode. +.quad foo