diff --git a/clang/include/clang/Basic/Attr.td b/clang/include/clang/Basic/Attr.td --- a/clang/include/clang/Basic/Attr.td +++ b/clang/include/clang/Basic/Attr.td @@ -1584,6 +1584,7 @@ let Spellings = [Clang<"preserve_access_index">]; let Subjects = SubjectList<[Record], ErrorDiag>; let Documentation = [BPFPreserveAccessIndexDocs]; + let LangOpts = [COnly]; } def WebAssemblyImportModule : InheritableAttr, diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp --- a/clang/lib/CodeGen/CGExpr.cpp +++ b/clang/lib/CodeGen/CGExpr.cpp @@ -3408,10 +3408,6 @@ if (!ArrayBase || !CGF.getDebugInfo()) return false; - const auto *ImplicitCast = dyn_cast(ArrayBase); - if (!ImplicitCast) - return false; - // Only support base as either a MemberExpr or DeclRefExpr. // DeclRefExpr to cover cases like: // struct s { int a; int b[10]; }; @@ -3419,39 +3415,24 @@ // p[1].a // p[1] will generate a DeclRefExpr and p[1].a is a MemberExpr. // p->b[5] is a MemberExpr example. - const Expr *E = ImplicitCast->getSubExpr(); - const auto *MemberCast = dyn_cast(E); - if (MemberCast) - return MemberCast->getMemberDecl()->hasAttr(); - - const auto *DeclRefCast = dyn_cast(E); - if (DeclRefCast) { - const VarDecl *VarDef = dyn_cast(DeclRefCast->getDecl()); + const Expr *E = ArrayBase->IgnoreImpCasts(); + if (const auto *ME = dyn_cast(E)) + return ME->getMemberDecl()->hasAttr(); + + if (const auto *DRE = dyn_cast(E)) { + const auto *VarDef = dyn_cast(DRE->getDecl()); if (!VarDef) return false; - const auto *PtrT = dyn_cast(VarDef->getType().getTypePtr()); + const auto *PtrT = VarDef->getType()->getAs(); if (!PtrT) return false; - const auto *PointeeT = PtrT->getPointeeType().getTypePtr(); - - // Peel off typedef's - const auto *TypedefT = dyn_cast(PointeeT); - while (TypedefT) { - PointeeT = TypedefT->desugar().getTypePtr(); - TypedefT = dyn_cast(PointeeT); - } - - // Not a typedef any more, it should be an elaborated type. - const auto ElaborateT = dyn_cast(PointeeT); - if (!ElaborateT) - return false; - const auto *RecT = dyn_cast(ElaborateT->desugar().getTypePtr()); - if (!RecT) - return false; - - return RecT->getDecl()->hasAttr(); + const auto *PointeeT = PtrT->getPointeeType().getTypePtr() + ->getUnqualifiedDesugaredType(); + if (const auto *RecT = dyn_cast(PointeeT)) + return RecT->getDecl()->hasAttr(); + return false; } return false; diff --git a/clang/test/Sema/bpf-attr-preserve-access-index.cpp b/clang/test/Sema/bpf-attr-preserve-access-index.cpp new file mode 100644 --- /dev/null +++ b/clang/test/Sema/bpf-attr-preserve-access-index.cpp @@ -0,0 +1,9 @@ +// RUN: %clang_cc1 -x c++ -triple bpf-pc-linux-gnu -dwarf-version=4 -fsyntax-only -verify %s + +#define __reloc__ __attribute__((preserve_access_index)) + +struct t1 { + int a; + int b[4]; + int c:1; +} __reloc__; // expected-warning {{'preserve_access_index' attribute ignored}}