Index: lldb/source/Plugins/Language/ClangCommon/ClangHighlighter.cpp
===================================================================
--- lldb/source/Plugins/Language/ClangCommon/ClangHighlighter.cpp
+++ lldb/source/Plugins/Language/ClangCommon/ClangHighlighter.cpp
@@ -139,6 +139,22 @@
FileManager file_mgr(file_opts,
FileSystem::Instance().GetVirtualFileSystem());
+ // The line might end in a backslash which would cause Clang to drop the
+ // backslash and the terminating new line. This makes sense when parsing C++,
+ // but when highlighting we care about preserving the backslash/newline. To
+ // not lose this information we remove the new line here so that Clang knows
+ // this is just a single line we are highlighting. We add back the newline
+ // after tokenizing.
+ llvm::StringRef line_ending = "";
+ // There are a few legal line endings Clang recognizes and we need to
+ // temporarily remove from the string.
+ if (line.consume_back("\r\n"))
+ line_ending = "\r\n";
+ else if (line.consume_back("\n"))
+ line_ending = "\n";
+ else if (line.consume_back("\r"))
+ line_ending = "\r";
+
unsigned line_number = previous_lines.count('\n') + 1U;
// Let's build the actual source code Clang needs and setup some utility
@@ -227,6 +243,9 @@
color.Apply(result, to_print);
}
+ // Add the line ending we trimmed before tokenizing.
+ result << line_ending;
+
// If we went over the whole file but couldn't find our own file, then
// somehow our setup was wrong. When we're in release mode we just give the
// user the normal line and pretend we don't know how to highlight it. In
Index: lldb/unittests/Language/Highlighting/HighlighterTest.cpp
===================================================================
--- lldb/unittests/Language/Highlighting/HighlighterTest.cpp
+++ lldb/unittests/Language/Highlighting/HighlighterTest.cpp
@@ -205,6 +205,44 @@
highlightC("#include \"foo\" //c", s));
}
+TEST_F(HighlighterTest, ClangPreserveNewLine) {
+ HighlightStyle s;
+ s.comment.Set("", "");
+
+ EXPECT_EQ("//\n", highlightC("//\n", s));
+}
+
+TEST_F(HighlighterTest, ClangTrailingBackslashBeforeNewline) {
+ HighlightStyle s;
+
+ EXPECT_EQ("\\\n", highlightC("\\\n", s));
+ EXPECT_EQ("\\\r\n", highlightC("\\\r\n", s));
+
+ EXPECT_EQ("#define a \\\n", highlightC("#define a \\\n", s));
+ EXPECT_EQ("#define a \\\r\n", highlightC("#define a \\\r\n", s));
+ EXPECT_EQ("#define a \\\r", highlightC("#define a \\\r", s));
+}
+
+TEST_F(HighlighterTest, ClangTrailingBackslashWithWhitespace) {
+ HighlightStyle s;
+
+ EXPECT_EQ("\\ \n", highlightC("\\ \n", s));
+ EXPECT_EQ("\\ \t\n", highlightC("\\ \t\n", s));
+ EXPECT_EQ("\\ \n", highlightC("\\ \n", s));
+ EXPECT_EQ("\\\t\n", highlightC("\\\t\n", s));
+
+ EXPECT_EQ("#define a \\ \n", highlightC("#define a \\ \n", s));
+ EXPECT_EQ("#define a \\ \t\n", highlightC("#define a \\ \t\n", s));
+ EXPECT_EQ("#define a \\ \n", highlightC("#define a \\ \n", s));
+ EXPECT_EQ("#define a \\\t\n", highlightC("#define a \\\t\n", s));
+}
+
+TEST_F(HighlighterTest, ClangTrailingBackslashMissingNewLine) {
+ HighlightStyle s;
+ EXPECT_EQ("\\", highlightC("\\", s));
+ EXPECT_EQ("#define a\\", highlightC("#define a\\", s));
+}
+
TEST_F(HighlighterTest, ClangComments) {
HighlightStyle s;
s.comment.Set("", "");