Update Fuchsia builder to use Git

[phosek]

Summary

This is part of the transition away from SVN to Git.

[gkistanova]

Thanks for changing this, Petr!

Looks good to me with one unclear place around handling the clean property. Please see my comment inline. If that behavior is intentional, it might worth a comment next to it explaining the reasoning.

With this addressed feel free to commit, please.

zorg/buildbot/builders/FuchsiaBuilder.py

73

Are you sure you always want to do a clean build, unless otherwise requested from the bot Web UI?

[phosek]

zorg/buildbot/builders/FuchsiaBuilder.py

73

Yes this is intentional. We're building a full toolchain and we've seen issues in the past when not doing a full build. I might come up with a better solution, and then re-evaluate this. Our builders are powerful enough that this shouldn't be an issue hopefully.

buildbot/osuosl/master/config/builders.py

def _get_libcxx_builders():
     ]
 
 # Toolchain builders.
 def _get_toolchain_builders():
       return [
           {'name': "fuchsia-x86_64-linux",
            'slavenames' :["fuchsia-debian-64-us-central1-a-1", "fuchsia-debian-64-us-central1-b-1"],
            'builddir': "fuchsia-x86_64-linux",
-           'factory': FuchsiaBuilder.getToolchainBuildFactory(),
+           'factory': FuchsiaBuilder.getFuchsiaToolchainBuildFactory(),
            'category': 'fuchsia'},
           {'name': "netbsd-amd64",
            'slavenames': ["netbsd-amd64"],
            'builddir': "netbsd8",
            'category' : 'netbsd',
            'factory': LLDBBuilder.getLLDBScriptCommandsFactory(
                       downloadBinary=False,
                       runTest=True,

zorg/buildbot/builders/FuchsiaBuilder.py

 import platform
 
 from buildbot.process.properties import WithProperties
 from buildbot.steps.shell import ShellCommand
 from buildbot.steps.slave import RemoveDirectory
-from buildbot.steps.source import SVN
 
+from zorg.buildbot.builders import UnifiedTreeBuilder
 from zorg.buildbot.commands.CmakeCommand import CmakeCommand
 from zorg.buildbot.commands.NinjaCommand import NinjaCommand
 from zorg.buildbot.conditions.FileConditions import FileDoesNotExist
-from zorg.buildbot.process.factory import LLVMBuildFactory, svn_repos
 
-def getToolchainBuildFactory(
-        clean=False,
+def getFuchsiaToolchainBuildFactory(
         test=True,
         env=None, # Environmental variables for all steps.
-        extra_configure_args=None):
+        extra_configure_args=None,
+        **kwargs):
     # Prepare environmental variables. Set here all env we want everywhere.
     merged_env = {
         "TERM" : "dumb", # Make sure Clang doesn't use color escape sequences.
     }
     if env is not None:
         # Overwrite pre-set items with the given ones, so user can set anything.
         merged_env.update(env)
 
     src_dir = "llvm.src"
     obj_dir = "llvm.obj"
     install_dir = "llvm.install"
 
-    f = LLVMBuildFactory(
+    f = UnifiedTreeBuilder.getLLVMBuildFactoryAndSourcecodeSteps(
             depends_on_projects=[
                 "llvm",
                 "clang",
                 "clang-tools-extra",
                 "compiler-rt",
                 "libcxx",
                 "libcxxabi",
                 "libunwind",
                 "lld"
-            ])
+            ],
+            llvm_srcdir=src_dir,
+            obj_dir=_obj_dir,
+            install_dir=install_dir,
+            **kwargs) # Pass through all the extra arguments.
 
     # Get Fuchsia SDK.
     sdk_dir = "fuchsia.sdk"
     sdk_platform = {
         "Linux": "linux-amd64",
         "Darwin": "mac-amd64",
     }[platform.system()]
     sdk_version = "latest"
f.addStep(ShellCommand(name="fetch-sdk",
                            description=["download", "fuchsia sdk"],
                            workdir=sdk_dir))
 
     f.addStep(ShellCommand(name="extract-sdk",
                            command=["unzip", "-fo", "sdk.cipd"],
                            description=["extract", "fuchsia sdk"],
                            workdir=sdk_dir))
 
-    cleanCheckoutRequested = lambda step: step.build.getProperty("clean", default=False) or clean
-
-    # Clean up llvm sources.
-    f.addStep(RemoveDirectory(name="clean-llvm.src",
-                              dir=src_dir,
-                              haltOnFailure=True,
-                              doStepIf=cleanCheckoutRequested))
-
-    # Get sources.
-    for project in f.depends_on_projects:
-        _, baseURL = svn_repos[project]
-        f.addStep(SVN(name="svn-%s" % project,
-                      workdir=src_dir + "/" + project,
-                      baseURL=baseURL))
-
-    cleanBuildRequested = lambda step: step.build.getProperty("clean", default=step.build.getProperty("clean_obj")) or clean
+    cleanBuildRequested = lambda step: step.build.getProperty("clean", default=True)
 
     # Clean up llvm build.
     f.addStep(RemoveDirectory(name="clean-llvm.obj",
                               dir=obj_dir,
                               haltOnFailure=True,
                               doStepIf=cleanBuildRequested))
 
+    f.addStep(RemoveDirectory(name="clean-llvm.install",
+                              dir=install_dir,
+                              haltOnFailure=True,
+                              doStepIf=cleanBuildRequested))
+
     # Configure.
     if extra_configure_args is None:
         cmake_options = []
     else:
         cmake_options = extra_configure_args[:]
 
     # Some options are required for this stage no matter what.
     CmakeCommand.applyRequiredOptions(cmake_options, [