Page MenuHomePhabricator

Update Fuchsia builder to use Git
ClosedPublic

Authored by phosek on Fri, Nov 8, 2:49 PM.

Details

Summary

This is part of the transition away from SVN to Git.

Diff Detail

Event Timeline

phosek created this revision.Fri, Nov 8, 2:49 PM
gkistanova accepted this revision.Mon, Nov 11, 11:28 AM

Thanks for changing this, Petr!

Looks good to me with one unclear place around handling the clean property. Please see my comment inline. If that behavior is intentional, it might worth a comment next to it explaining the reasoning.

With this addressed feel free to commit, please.

zorg/buildbot/builders/FuchsiaBuilder.py
73

Are you sure you always want to do a clean build, unless otherwise requested from the bot Web UI?

This revision is now accepted and ready to land.Mon, Nov 11, 11:28 AM
phosek marked an inline comment as done.Mon, Nov 11, 3:18 PM
phosek added inline comments.
zorg/buildbot/builders/FuchsiaBuilder.py
73

Yes this is intentional. We're building a full toolchain and we've seen issues in the past when not doing a full build. I might come up with a better solution, and then re-evaluate this. Our builders are powerful enough that this shouldn't be an issue hopefully.

This revision was automatically updated to reflect the committed changes.