Page MenuHomePhabricator

[PPC64] Implement the ICBT Instruction for POWER8
ClosedPublic

Authored by kbarton on Jan 14 2015, 8:14 AM.

Details

Reviewers
wschmidt
hfinkel
Summary

Add support for the ICBT instruction on POWER8.
Support for the ICBT instruction is currently present, but limited to embedded processors. This change adds a new FeatureICBT that can be used to identify whether the ICBT instruction is available on a specific processor.

Diff Detail

Event Timeline

kbarton updated this revision to Diff 18157.Jan 14 2015, 8:14 AM
kbarton retitled this revision from to [PPC64] Implement the ICBT Instruction for POWER8.
kbarton updated this object.
kbarton edited the test plan for this revision. (Show Details)
kbarton added reviewers: hfinkel, wschmidt.
kbarton added a subscriber: Unknown Object (MLST).
hfinkel accepted this revision.Jan 14 2015, 8:36 AM
hfinkel edited edge metadata.

LGTM.

test/CodeGen/PowerPC/ppc64-icbt-pwr7.ll
4

Please add a FIXME to this test. Crashing is not really the correct behavior here, we really should just emit nothing.

This revision is now accepted and ready to land.Jan 14 2015, 8:36 AM
kbarton updated this revision to Diff 18164.Jan 14 2015, 9:57 AM
kbarton edited edge metadata.

Added FIXME to ppc64-icbt-pwr7.ll test case to address Hal's comments.

wschmidt accepted this revision.Jan 14 2015, 10:05 AM
wschmidt edited edge metadata.

Looks good here as well. I'll commit on your behalf this afternoon. Thanks!

kbarton closed this revision.Feb 3 2015, 7:26 AM

Work is complete.