A build factory for libc has been added. This factory makes use of an
annotated step runner.
Details
Details
- Reviewers
vitalybuka gkistanova - Commits
- rZORG6d5695aea629: Add llvm-libc builders.
Diff Detail
Diff Detail
- Repository
- rZORG LLVM Github Zorg
Event Timeline
Comment Actions
Thanks for working on this, Siva!
This patch needs a bit more work before it could successfully land.
First of all, it looks like you do not really need a new build factory. You can use AnnotatedBuilder for your purpose. If it misses anything, please feel free to propose a patch improving that factory.
Then, no need to add a scheduler. An automatic scheduler will be assigned to your builder.
Besides that, could you split this patch to a few, since some changes are not related or there is sequential dependency chain.
And for the future. With the relatively large changes, could you let a review item open for long enough so people in different time zones would have a chance to look at it, please?
Thanks
Galina