Page MenuHomePhabricator

Add weak symbol support to RuntimeDyld
ClosedPublic

Authored by loladiro on Jan 13 2015, 7:47 AM.

Details

Summary

Support weak symbols by first looking up if there is an externally visible symbol we can find, and only if that fails using the one in the object file we're loading. I'd like some feedback if these semantics seem correct, since the semantics of weak symbols during dynamic linking are always tricky.

Diff Detail

Repository
rL LLVM

Event Timeline

loladiro updated this revision to Diff 18086.Jan 13 2015, 7:47 AM
loladiro retitled this revision from to Add weak symbol support to RuntimeDyld.
loladiro updated this object.
loladiro edited the test plan for this revision. (Show Details)
loladiro added a reviewer: lhames.
loladiro set the repository for this revision to rL LLVM.
loladiro added a subscriber: Unknown Object (MLST).
lhames accepted this revision.Jan 20 2015, 2:44 PM
lhames edited edge metadata.

This looks good to me. Thanks Keno!

This revision is now accepted and ready to land.Jan 20 2015, 2:44 PM
This revision was automatically updated to reflect the committed changes.