diff --git a/llvm/lib/Target/AArch64/AArch64TargetMachine.cpp b/llvm/lib/Target/AArch64/AArch64TargetMachine.cpp --- a/llvm/lib/Target/AArch64/AArch64TargetMachine.cpp +++ b/llvm/lib/Target/AArch64/AArch64TargetMachine.cpp @@ -614,14 +614,15 @@ if (EnableA53Fix835769) addPass(createAArch64A53Fix835769()); + + if (EnableBranchTargets) + addPass(createAArch64BranchTargetsPass()); + // Relax conditional branch instructions if they're otherwise out of // range of their destination. if (BranchRelaxation) addPass(&BranchRelaxationPassID); - if (EnableBranchTargets) - addPass(createAArch64BranchTargetsPass()); - // Identify valid longjmp targets for Windows Control Flow Guard. if (TM->getTargetTriple().isOSWindows()) addPass(createCFGuardLongjmpPass()); diff --git a/llvm/test/CodeGen/AArch64/O0-pipeline.ll b/llvm/test/CodeGen/AArch64/O0-pipeline.ll --- a/llvm/test/CodeGen/AArch64/O0-pipeline.ll +++ b/llvm/test/CodeGen/AArch64/O0-pipeline.ll @@ -58,8 +58,8 @@ ; CHECK-NEXT: AArch64 pseudo instruction expansion pass ; CHECK-NEXT: AArch64 speculation hardening pass ; CHECK-NEXT: Analyze Machine Code For Garbage Collection -; CHECK-NEXT: Branch relaxation pass ; CHECK-NEXT: AArch64 Branch Targets +; CHECK-NEXT: Branch relaxation pass ; CHECK-NEXT: Contiguously Lay Out Funclets ; CHECK-NEXT: StackMap Liveness Analysis ; CHECK-NEXT: Live DEBUG_VALUE analysis diff --git a/llvm/test/CodeGen/AArch64/O3-pipeline.ll b/llvm/test/CodeGen/AArch64/O3-pipeline.ll --- a/llvm/test/CodeGen/AArch64/O3-pipeline.ll +++ b/llvm/test/CodeGen/AArch64/O3-pipeline.ll @@ -164,8 +164,8 @@ ; CHECK-NEXT: MachinePostDominator Tree Construction ; CHECK-NEXT: Branch Probability Basic Block Placement ; CHECK-NEXT: AArch64 load / store optimization pass -; CHECK-NEXT: Branch relaxation pass ; CHECK-NEXT: AArch64 Branch Targets +; CHECK-NEXT: Branch relaxation pass ; CHECK-NEXT: AArch64 Compress Jump Tables ; CHECK-NEXT: Contiguously Lay Out Funclets ; CHECK-NEXT: StackMap Liveness Analysis diff --git a/llvm/test/CodeGen/AArch64/bti-branch-relaxation.ll b/llvm/test/CodeGen/AArch64/bti-branch-relaxation.ll new file mode 100644 --- /dev/null +++ b/llvm/test/CodeGen/AArch64/bti-branch-relaxation.ll @@ -0,0 +1,64 @@ +; RUN: llc %s -o - | FileCheck %s +target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128" +target triple = "aarch64-unknown-unknown-eabi" + +; Function Attrs: nounwind +define dso_local void @f(i64 %v) local_unnamed_addr #0 { +entry: + %call = tail call i32 bitcast (i32 (...)* @test to i32 ()*)() #0 + %and = and i32 %call, 2 + %cmp = icmp eq i32 %and, 0 + br i1 %cmp, label %if.then, label %if.else +; CHECK: tbz +; CHECK-NEXT: b +if.then: ; preds = %entry + switch i64 %v, label %sw.epilog [ + i64 0, label %sw.bb + i64 1, label %sw.bb1 + i64 2, label %sw.bb2 + i64 3, label %sw.bb3 + ] + +sw.bb: ; preds = %if.then + tail call void bitcast (void (...)* @g0 to void ()*)() #0 + br label %sw.bb1 + +sw.bb1: ; preds = %if.then, %sw.bb + tail call void bitcast (void (...)* @g1 to void ()*)() #0 + br label %sw.bb2 + +sw.bb2: ; preds = %if.then, %sw.bb1 + tail call void bitcast (void (...)* @g2 to void ()*)() #0 + br label %sw.bb3 + +sw.bb3: ; preds = %if.then, %sw.bb2 + tail call void bitcast (void (...)* @g3 to void ()*)() #0 + br label %sw.epilog + +sw.epilog: ; preds = %sw.bb3, %if.then + %dummy = tail call i64 @llvm.aarch64.space(i32 32700, i64 %v) + br label %if.end + +if.else: ; preds = %entry + tail call void bitcast (void (...)* @e to void ()*)() #0 + br label %if.end + +if.end: ; preds = %if.else, %sw.epilog + ret void +} + +declare dso_local i32 @test(...) local_unnamed_addr #0 + +declare dso_local void @g0(...) local_unnamed_addr #0 + +declare dso_local void @g1(...) local_unnamed_addr #0 + +declare dso_local void @g2(...) local_unnamed_addr #0 + +declare dso_local void @g3(...) local_unnamed_addr #0 + +declare dso_local void @e(...) local_unnamed_addr #0 + +declare dso_local i64 @llvm.aarch64.space(i32, i64) local_unnamed_addr #0 + +attributes #0 = { nounwind "branch-target-enforcement" "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="generic" "target-features"="+neon,+v8.5a" "unsafe-fp-math"="false" "use-soft-float"="false" }