diff --git a/llvm/lib/Target/AMDGPU/DSInstructions.td b/llvm/lib/Target/AMDGPU/DSInstructions.td --- a/llvm/lib/Target/AMDGPU/DSInstructions.td +++ b/llvm/lib/Target/AMDGPU/DSInstructions.td @@ -81,6 +81,17 @@ // DS Pseudo instructions +class DS_0A1D_NORET +: DS_Pseudo { + + let has_addr = 0; + let has_data1 = 0; + let has_vdst = 0; +} + class DS_1A1D_NORET : DS_Pseudo; } +} // End has_m0_read = 0 + let SubtargetPredicate = HasDSAddTid in { -def DS_WRITE_ADDTID_B32 : DS_1A1D_NORET<"ds_write_addtid_b32">; +def DS_WRITE_ADDTID_B32 : DS_0A1D_NORET<"ds_write_addtid_b32">; } -} // End has_m0_read = 0 } // End mayLoad = 0 defm DS_MSKOR_B32 : DS_1A2D_NORET_mc<"ds_mskor_b32">; @@ -543,13 +555,14 @@ def DS_READ_U16_D16 : DS_1A_RET_Tied<"ds_read_u16_d16">; def DS_READ_U16_D16_HI : DS_1A_RET_Tied<"ds_read_u16_d16_hi">; } +} // End has_m0_read = 0 let SubtargetPredicate = HasDSAddTid in { -def DS_READ_ADDTID_B32 : DS_1A_RET<"ds_read_addtid_b32">; -} -} // End has_m0_read = 0 +def DS_READ_ADDTID_B32 : DS_0A_RET<"ds_read_addtid_b32">; } +} // End mayStore = 0 + def DS_CONSUME : DS_0A_RET<"ds_consume">; def DS_APPEND : DS_0A_RET<"ds_append">; def DS_ORDERED_COUNT : DS_1A_RET_GDS<"ds_ordered_count">; diff --git a/llvm/test/MC/AMDGPU/ds-gfx9.s b/llvm/test/MC/AMDGPU/ds-gfx9.s --- a/llvm/test/MC/AMDGPU/ds-gfx9.s +++ b/llvm/test/MC/AMDGPU/ds-gfx9.s @@ -33,10 +33,10 @@ // VI-ERR: error: instruction not supported on this GPU // GFX9: ds_write_b16_d16_hi v8, v2 ; encoding: [0x00,0x00,0xaa,0xd8,0x08,0x02,0x00,0x00] -ds_write_addtid_b32 v8, v2 +ds_write_addtid_b32 v8 // VI-ERR: error: instruction not supported on this GPU -// GFX9: ds_write_addtid_b32 v8, v2 ; encoding: [0x00,0x00,0x3a,0xd8,0x08,0x02,0x00,0x00] +// GFX9: ds_write_addtid_b32 v8 ; encoding: [0x00,0x00,0x3a,0xd8,0x00,0x08,0x00,0x00] -ds_read_addtid_b32 v8, v2 +ds_read_addtid_b32 v8 // VI-ERR: error: instruction not supported on this GPU -// GFX9: ds_read_addtid_b32 v8, v2 ; encoding: [0x00,0x00,0x6c,0xd9,0x02,0x00,0x00,0x08] +// GFX9: ds_read_addtid_b32 v8 ; encoding: [0x00,0x00,0x6c,0xd9,0x00,0x00,0x00,0x08] diff --git a/llvm/test/MC/AMDGPU/gfx10_asm_all.s b/llvm/test/MC/AMDGPU/gfx10_asm_all.s --- a/llvm/test/MC/AMDGPU/gfx10_asm_all.s +++ b/llvm/test/MC/AMDGPU/gfx10_asm_all.s @@ -6538,47 +6538,47 @@ ds_read_u16_d16_hi v5, v1 offset:65535 gds // GFX10: encoding: [0xff,0xff,0x9e,0xda,0x01,0x00,0x00,0x05] -ds_write_addtid_b32 v5, v1 offset:65535 -// GFX10: encoding: [0xff,0xff,0xc0,0xda,0x05,0x01,0x00,0x00] +ds_write_addtid_b32 v5 offset:65535 +// GFX10: encoding: [0xff,0xff,0xc0,0xda,0x00,0x05,0x00,0x00] -ds_write_addtid_b32 v255, v1 offset:65535 -// GFX10: encoding: [0xff,0xff,0xc0,0xda,0xff,0x01,0x00,0x00] +ds_write_addtid_b32 v255 offset:65535 +// GFX10: encoding: [0xff,0xff,0xc0,0xda,0x00,0xff,0x00,0x00] -ds_write_addtid_b32 v5, v255 offset:65535 -// GFX10: encoding: [0xff,0xff,0xc0,0xda,0x05,0xff,0x00,0x00] +ds_write_addtid_b32 v5 offset:65535 +// GFX10: encoding: [0xff,0xff,0xc0,0xda,0x00,0x05,0x00,0x00] -ds_write_addtid_b32 v5, v1 -// GFX10: encoding: [0x00,0x00,0xc0,0xda,0x05,0x01,0x00,0x00] +ds_write_addtid_b32 v5 +// GFX10: encoding: [0x00,0x00,0xc0,0xda,0x00,0x05,0x00,0x00] -ds_write_addtid_b32 v5, v1 offset:0 -// GFX10: encoding: [0x00,0x00,0xc0,0xda,0x05,0x01,0x00,0x00] +ds_write_addtid_b32 v5 offset:0 +// GFX10: encoding: [0x00,0x00,0xc0,0xda,0x00,0x05,0x00,0x00] -ds_write_addtid_b32 v5, v1 offset:4 -// GFX10: encoding: [0x04,0x00,0xc0,0xda,0x05,0x01,0x00,0x00] +ds_write_addtid_b32 v5 offset:4 +// GFX10: encoding: [0x04,0x00,0xc0,0xda,0x00,0x05,0x00,0x00] -ds_write_addtid_b32 v5, v1 offset:65535 gds -// GFX10: encoding: [0xff,0xff,0xc2,0xda,0x05,0x01,0x00,0x00] +ds_write_addtid_b32 v5 offset:65535 gds +// GFX10: encoding: [0xff,0xff,0xc2,0xda,0x00,0x05,0x00,0x00] -ds_read_addtid_b32 v5, v1 offset:65535 -// GFX10: encoding: [0xff,0xff,0xc4,0xda,0x01,0x00,0x00,0x05] +ds_read_addtid_b32 v5 offset:65535 +// GFX10: encoding: [0xff,0xff,0xc4,0xda,0x00,0x00,0x00,0x05] -ds_read_addtid_b32 v255, v1 offset:65535 -// GFX10: encoding: [0xff,0xff,0xc4,0xda,0x01,0x00,0x00,0xff] +ds_read_addtid_b32 v255 offset:65535 +// GFX10: encoding: [0xff,0xff,0xc4,0xda,0x00,0x00,0x00,0xff] -ds_read_addtid_b32 v5, v255 offset:65535 -// GFX10: encoding: [0xff,0xff,0xc4,0xda,0xff,0x00,0x00,0x05] +ds_read_addtid_b32 v5 offset:65535 +// GFX10: encoding: [0xff,0xff,0xc4,0xda,0x00,0x00,0x00,0x05] -ds_read_addtid_b32 v5, v1 -// GFX10: encoding: [0x00,0x00,0xc4,0xda,0x01,0x00,0x00,0x05] +ds_read_addtid_b32 v5 +// GFX10: encoding: [0x00,0x00,0xc4,0xda,0x00,0x00,0x00,0x05] -ds_read_addtid_b32 v5, v1 offset:0 -// GFX10: encoding: [0x00,0x00,0xc4,0xda,0x01,0x00,0x00,0x05] +ds_read_addtid_b32 v5 offset:0 +// GFX10: encoding: [0x00,0x00,0xc4,0xda,0x00,0x00,0x00,0x05] -ds_read_addtid_b32 v5, v1 offset:4 -// GFX10: encoding: [0x04,0x00,0xc4,0xda,0x01,0x00,0x00,0x05] +ds_read_addtid_b32 v5 offset:4 +// GFX10: encoding: [0x04,0x00,0xc4,0xda,0x00,0x00,0x00,0x05] -ds_read_addtid_b32 v5, v1 offset:65535 gds -// GFX10: encoding: [0xff,0xff,0xc6,0xda,0x01,0x00,0x00,0x05] +ds_read_addtid_b32 v5 offset:65535 gds +// GFX10: encoding: [0xff,0xff,0xc6,0xda,0x00,0x00,0x00,0x05] ds_permute_b32 v0, v1, v2 // GFX10: encoding: [0x00,0x00,0xc8,0xda,0x01,0x02,0x00,0x00] diff --git a/llvm/test/MC/AMDGPU/gfx10_asm_err.s b/llvm/test/MC/AMDGPU/gfx10_asm_err.s --- a/llvm/test/MC/AMDGPU/gfx10_asm_err.s +++ b/llvm/test/MC/AMDGPU/gfx10_asm_err.s @@ -35,10 +35,10 @@ ds_read_u16_d16_hi v5, v1 // GFX6-8: error: instruction not supported on this GPU -ds_write_addtid_b32 v5, v1 +ds_write_addtid_b32 v5 // GFX6-8: error: instruction not supported on this GPU -ds_read_addtid_b32 v5, v1 +ds_read_addtid_b32 v5 // GFX6-8: error: instruction not supported on this GPU // GFX8+. diff --git a/llvm/test/MC/Disassembler/AMDGPU/gfx10_dasm_all.txt b/llvm/test/MC/Disassembler/AMDGPU/gfx10_dasm_all.txt --- a/llvm/test/MC/Disassembler/AMDGPU/gfx10_dasm_all.txt +++ b/llvm/test/MC/Disassembler/AMDGPU/gfx10_dasm_all.txt @@ -5762,23 +5762,23 @@ # GFX10: ds_read2st64_b64 v[5:8], v255 offset0:127 offset1:255 ; encoding: [0x7f,0xff,0xe0,0xd9,0xff,0x00,0x00,0x05] 0x7f,0xff,0xe0,0xd9,0xff,0x00,0x00,0x05 -# GFX10: ds_read_addtid_b32 v255, v1 offset:65535 ; encoding: [0xff,0xff,0xc4,0xda,0x01,0x00,0x00,0xff] -0xff,0xff,0xc4,0xda,0x01,0x00,0x00,0xff +# GFX10: ds_read_addtid_b32 v255 offset:65535 ; encoding: [0xff,0xff,0xc4,0xda,0x00,0x00,0x00,0xff] +0xff 0xff 0xc4 0xda 0x00 0x00 0x00 0xff -# GFX10: ds_read_addtid_b32 v5, v1 ; encoding: [0x00,0x00,0xc4,0xda,0x01,0x00,0x00,0x05] -0x00,0x00,0xc4,0xda,0x01,0x00,0x00,0x05 +# GFX10: ds_read_addtid_b32 v5 ; encoding: [0x00,0x00,0xc4,0xda,0x00,0x00,0x00,0x05] +0x00 0x00 0xc4 0xda 0x00 0x00 0x00 0x05 -# GFX10: ds_read_addtid_b32 v5, v1 offset:4 ; encoding: [0x04,0x00,0xc4,0xda,0x01,0x00,0x00,0x05] -0x04,0x00,0xc4,0xda,0x01,0x00,0x00,0x05 +# GFX10: ds_read_addtid_b32 v5 offset:4 ; encoding: [0x04,0x00,0xc4,0xda,0x00,0x00,0x00,0x05] +0x04 0x00 0xc4 0xda 0x00 0x00 0x00 0x05 -# GFX10: ds_read_addtid_b32 v5, v1 offset:65535 ; encoding: [0xff,0xff,0xc4,0xda,0x01,0x00,0x00,0x05] -0xff,0xff,0xc4,0xda,0x01,0x00,0x00,0x05 +# GFX10: ds_read_addtid_b32 v5 offset:65535 ; encoding: [0xff,0xff,0xc4,0xda,0x00,0x00,0x00,0x05] +0xff 0xff 0xc4 0xda 0x00 0x00 0x00 0x05 -# GFX10: ds_read_addtid_b32 v5, v1 offset:65535 gds ; encoding: [0xff,0xff,0xc6,0xda,0x01,0x00,0x00,0x05] -0xff,0xff,0xc6,0xda,0x01,0x00,0x00,0x05 +# GFX10: ds_read_addtid_b32 v5 offset:65535 gds ; encoding: [0xff,0xff,0xc6,0xda,0x00,0x00,0x00,0x05] +0xff 0xff 0xc6 0xda 0x00 0x00 0x00 0x05 -# GFX10: ds_read_addtid_b32 v5, v255 offset:65535 ; encoding: [0xff,0xff,0xc4,0xda,0xff,0x00,0x00,0x05] -0xff,0xff,0xc4,0xda,0xff,0x00,0x00,0x05 +# GFX10: ds_read_addtid_b32 v5 offset:65535 ; encoding: [0xff,0xff,0xc4,0xda,0x00,0x00,0x00,0x05] +0xff 0xff 0xc4 0xda 0x00 0x00 0x00 0x05 # GFX10: ds_read_b128 v[252:255], v1 offset:65535 ; encoding: [0xff,0xff,0xfc,0xdb,0x01,0x00,0x00,0xfc] 0xff,0xff,0xfc,0xdb,0x01,0x00,0x00,0xfc @@ -7070,23 +7070,23 @@ # GFX10: ds_write2st64_b64 v255, v[2:3], v[3:4] offset0:127 offset1:255 ; encoding: [0x7f,0xff,0x3c,0xd9,0xff,0x02,0x03,0x00] 0x7f,0xff,0x3c,0xd9,0xff,0x02,0x03,0x00 -# GFX10: ds_write_addtid_b32 v255, v1 offset:65535 ; encoding: [0xff,0xff,0xc0,0xda,0xff,0x01,0x00,0x00] -0xff,0xff,0xc0,0xda,0xff,0x01,0x00,0x00 +# GFX10: ds_write_addtid_b32 v255 offset:65535 ; encoding: [0xff,0xff,0xc0,0xda,0x00,0xff,0x00,0x00] +0xff 0xff 0xc0 0xda 0x00 0xff 0x00 0x00 -# GFX10: ds_write_addtid_b32 v5, v1 ; encoding: [0x00,0x00,0xc0,0xda,0x05,0x01,0x00,0x00] -0x00,0x00,0xc0,0xda,0x05,0x01,0x00,0x00 +# GFX10: ds_write_addtid_b32 v5 ; encoding: [0x00,0x00,0xc0,0xda,0x00,0x05,0x00,0x00] +0x00 0x00 0xc0 0xda 0x00 0x05 0x00 0x00 -# GFX10: ds_write_addtid_b32 v5, v1 offset:4 ; encoding: [0x04,0x00,0xc0,0xda,0x05,0x01,0x00,0x00] -0x04,0x00,0xc0,0xda,0x05,0x01,0x00,0x00 +# GFX10: ds_write_addtid_b32 v5 offset:4 ; encoding: [0x04,0x00,0xc0,0xda,0x00,0x05,0x00,0x00] +0x04 0x00 0xc0 0xda 0x00 0x05 0x00 0x00 -# GFX10: ds_write_addtid_b32 v5, v1 offset:65535 ; encoding: [0xff,0xff,0xc0,0xda,0x05,0x01,0x00,0x00] -0xff,0xff,0xc0,0xda,0x05,0x01,0x00,0x00 +# GFX10: ds_write_addtid_b32 v5 offset:65535 ; encoding: [0xff,0xff,0xc0,0xda,0x00,0x05,0x00,0x00] +0xff 0xff 0xc0 0xda 0x00 0x05 0x00 0x00 -# GFX10: ds_write_addtid_b32 v5, v1 offset:65535 gds ; encoding: [0xff,0xff,0xc2,0xda,0x05,0x01,0x00,0x00] -0xff,0xff,0xc2,0xda,0x05,0x01,0x00,0x00 +# GFX10: ds_write_addtid_b32 v5 offset:65535 gds ; encoding: [0xff,0xff,0xc2,0xda,0x00,0x05,0x00,0x00] +0xff 0xff 0xc2 0xda 0x00 0x05 0x00 0x00 -# GFX10: ds_write_addtid_b32 v5, v255 offset:65535 ; encoding: [0xff,0xff,0xc0,0xda,0x05,0xff,0x00,0x00] -0xff,0xff,0xc0,0xda,0x05,0xff,0x00,0x00 +# GFX10: ds_write_addtid_b32 v5 offset:65535 ; encoding: [0xff,0xff,0xc0,0xda,0x00,0x05,0x00,0x00] +0xff 0xff 0xc0 0xda 0x00 0x05 0x00 0x00 # GFX10: ds_write_b128 v1, v[252:255] offset:65535 ; encoding: [0xff,0xff,0x7c,0xdb,0x01,0xfc,0x00,0x00] 0xff,0xff,0x7c,0xdb,0x01,0xfc,0x00,0x00