This is an archive of the discontinued LLVM Phabricator instance.

Differential D68731

Remove CC autodetection from Makefile.rules
ClosedPublic

Authored by aprantl on Oct 9 2019, 2:19 PM.

Details

Reviewers
friss
JDevlieghere
labath
Commits
rG6a07b99c90e5: Remove CC autodetection from Makefile.rules
rL374402: Remove CC autodetection from Makefile.rules
rLLDB374402: Remove CC autodetection from Makefile.rules
Summary

Auto-detecting CC in Makefile.rules is no longer useful. Every since out-of-tree builds you are better off just running lldb-dotest which sets it directly. This also makes it harder to accidentally unset CC in a Makefile.

Diff Detail

Event Timeline

aprantl created this revision.Oct 9 2019, 2:19 PM
JDevlieghere accepted this revision.Oct 9 2019, 5:20 PM
This revision is now accepted and ready to land.Oct 9 2019, 5:20 PM
labath accepted this revision.Oct 10 2019, 12:54 AM

Yay

labath mentioned this in D68755: [test] Use a different module cache for Shell and API tests..Oct 10 2019, 1:05 AM
Closed by commit rG6a07b99c90e5: Remove CC autodetection from Makefile.rules (authored by aprantl). · Explain WhyOct 10 2019, 11:03 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 10 2019, 11:03 AM

Revision Contents

PathSize
lldb/
packages/
Python/
lldbsuite/
test/
make/
11 lines

Diff 224418

lldb/packages/Python/lldbsuite/test/make/Makefile.rules

Show First 20 Lines • Show All 165 Lines • ▼ Show 20 Lines
# If you change the defaults of CC, be sure to also change it in the file # If you change the defaults of CC, be sure to also change it in the file
# test/plugins/builder_base.py, which provides a Python way to return the # test/plugins/builder_base.py, which provides a Python way to return the
# value of the make variable CC -- getCompiler(). # value of the make variable CC -- getCompiler().
# #
# See also these functions: # See also these functions:
# o cxx_compiler # o cxx_compiler
# o cxx_linker # o cxx_linker
#---------------------------------------------------------------------- #----------------------------------------------------------------------
CC ?= clang ifeq "$(CC)" ""
ifeq "$(CC)" "cc" $(error "C compiler is not specified. Please run tests through lldb-dotest or lit")
ifneq "$(shell which clang)" ""
CC = clang
else ifneq "$(shell which clang-3.5)" ""
CC = clang-3.5
else ifneq "$(shell which gcc)" ""
CC = gcc
endif
endif endif
#---------------------------------------------------------------------- #----------------------------------------------------------------------
# Handle SDKROOT on Darwin # Handle SDKROOT on Darwin
#---------------------------------------------------------------------- #----------------------------------------------------------------------
ifeq "$(OS)" "Darwin" ifeq "$(OS)" "Darwin"
ifeq "$(SDKROOT)" "" ifeq "$(SDKROOT)" ""
▲ Show 20 Lines • Show All 592 Lines • Show Last 20 Lines