Index: clang-tools-extra/trunk/clangd/FindTarget.cpp =================================================================== --- clang-tools-extra/trunk/clangd/FindTarget.cpp +++ clang-tools-extra/trunk/clangd/FindTarget.cpp @@ -477,13 +477,6 @@ Ref->Qualifier = L.getQualifierLoc(); } - void VisitDeducedTemplateSpecializationTypeLoc( - DeducedTemplateSpecializationTypeLoc L) { - Ref = ReferenceLoc{ - NestedNameSpecifierLoc(), L.getNameLoc(), - explicitReferenceTargets(DynTypedNode::create(L.getType()))}; - } - void VisitTagTypeLoc(TagTypeLoc L) { Ref = ReferenceLoc{NestedNameSpecifierLoc(), L.getNameLoc(), {L.getDecl()}}; @@ -495,9 +488,25 @@ } void VisitTemplateSpecializationTypeLoc(TemplateSpecializationTypeLoc L) { + // We must ensure template type aliases are included in results if they + // were written in the source code, e.g. in + // template using valias = vector; + // ^valias x; + // 'explicitReferenceTargets' will return: + // 1. valias with mask 'Alias'. + // 2. 'vector' with mask 'Underlying'. + // we want to return only #1 in this case. Ref = ReferenceLoc{ NestedNameSpecifierLoc(), L.getTemplateNameLoc(), - explicitReferenceTargets(DynTypedNode::create(L.getType()))}; + explicitReferenceTargets(DynTypedNode::create(L.getType()), + DeclRelation::Alias)}; + } + void VisitDeducedTemplateSpecializationTypeLoc( + DeducedTemplateSpecializationTypeLoc L) { + Ref = ReferenceLoc{ + NestedNameSpecifierLoc(), L.getNameLoc(), + explicitReferenceTargets(DynTypedNode::create(L.getType()), + DeclRelation::Alias)}; } void VisitDependentTemplateSpecializationTypeLoc( Index: clang-tools-extra/trunk/clangd/unittests/FindTargetTests.cpp =================================================================== --- clang-tools-extra/trunk/clangd/unittests/FindTargetTests.cpp +++ clang-tools-extra/trunk/clangd/unittests/FindTargetTests.cpp @@ -615,20 +615,18 @@ )cpp", "0: targets = {vector}\n" "1: targets = {vector}\n"}, - // FIXME: Fix 'allTargetDecls' to return alias template and re-enable. // Template type aliases. - // {R"cpp( - // template struct vector { using value_type = T; }; - // template <> struct vector { using value_type = bool; }; - // template using valias = vector; - // void foo() { - // $0^valias vi; - // $1^valias vb; - // } - // )cpp", - // "0: targets = {valias}\n" - // "1: targets = {valias}\n"}, - + {R"cpp( + template struct vector { using value_type = T; }; + template <> struct vector { using value_type = bool; }; + template using valias = vector; + void foo() { + $0^valias vi; + $1^valias vb; + } + )cpp", + "0: targets = {valias}\n" + "1: targets = {valias}\n"}, // MemberExpr should know their using declaration. {R"cpp( struct X { void func(int); }