Index: lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManyBreakpoints.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManyBreakpoints.py +++ lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManyBreakpoints.py @@ -15,6 +15,7 @@ # Atomic sequences are not supported yet for MIPS in LLDB. @skipIf(triple='^mips') @expectedFailureNetBSD + @skipIfOutOfTreeDebugserver def test(self): """Test 100 breakpoints from 100 threads.""" self.build(dictionary=self.getBuildFlags()) Index: lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManyCrash.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManyCrash.py +++ lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManyCrash.py @@ -15,6 +15,7 @@ # Atomic sequences are not supported yet for MIPS in LLDB. @skipIf(triple='^mips') @expectedFailureNetBSD + @skipIfOutOfTreeDebugserver def test(self): """Test 100 threads that cause a segfault.""" self.build(dictionary=self.getBuildFlags()) Index: lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManySignals.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManySignals.py +++ lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManySignals.py @@ -17,6 +17,7 @@ # This test is flaky on Darwin. @skipIfDarwin @expectedFailureNetBSD + @skipIfOutOfTreeDebugserver def test(self): """Test 100 signals from 100 threads.""" self.build(dictionary=self.getBuildFlags()) Index: lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManyWatchpoints.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManyWatchpoints.py +++ lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManyWatchpoints.py @@ -16,6 +16,7 @@ @skipIf(triple='^mips') @expectedFailureNetBSD @add_test_categories(["watchpoint"]) + @skipIfOutOfTreeDebugserver def test(self): """Test 100 watchpoints from 100 threads.""" self.build(dictionary=self.getBuildFlags()) Index: lldb/test/CMakeLists.txt =================================================================== --- lldb/test/CMakeLists.txt +++ lldb/test/CMakeLists.txt @@ -97,6 +97,10 @@ if(LLDB_USE_SYSTEM_DEBUGSERVER) lldb_find_system_debugserver(system_debugserver_path) + add_custom_target(debugserver + COMMAND ${CMAKE_COMMAND} -E copy_if_different + ${system_debugserver_path} ${LLVM_RUNTIME_OUTPUT_INTDIR} + COMMENT "Copying the system debugserver to LLDB's binaries directory for testing.") message(STATUS "LLDB tests use out-of-tree debugserver: ${system_debugserver_path}") list(APPEND LLDB_TEST_COMMON_ARGS --out-of-tree-debugserver) elseif(TARGET debugserver) Index: lldb/tools/CMakeLists.txt =================================================================== --- lldb/tools/CMakeLists.txt +++ lldb/tools/CMakeLists.txt @@ -12,7 +12,9 @@ if (CMAKE_SYSTEM_NAME MATCHES "Darwin") add_lldb_tool_subdirectory(darwin-debug) - add_lldb_tool_subdirectory(debugserver) + if(NOT LLDB_USE_SYSTEM_DEBUGSERVER) + add_lldb_tool_subdirectory(debugserver) + endif() endif() if (LLDB_CAN_USE_LLDB_SERVER) Index: lldb/tools/debugserver/source/CMakeLists.txt =================================================================== --- lldb/tools/debugserver/source/CMakeLists.txt +++ lldb/tools/debugserver/source/CMakeLists.txt @@ -28,7 +28,7 @@ if(LLDB_CODESIGN_IDENTITY) set(${result} ${LLDB_CODESIGN_IDENTITY} PARENT_SCOPE) check_certificate(${LLDB_CODESIGN_IDENTITY} available) - if(NOT available AND NOT LLDB_USE_SYSTEM_DEBUGSERVER) + if(NOT available) message(WARNING "LLDB_CODESIGN_IDENTITY not found: '${LLDB_CODESIGN_IDENTITY}' ${not_found_help}") endif() return() @@ -41,9 +41,7 @@ return() endif() - if(NOT LLDB_USE_SYSTEM_DEBUGSERVER) - message(WARNING "Development code sign identiy not found: 'lldb_codesign' ${not_found_help}") - endif() + message(WARNING "Development code sign identiy not found: 'lldb_codesign' ${not_found_help}") # LLVM pendant: fallback if available if(LLVM_CODESIGNING_IDENTITY)