This is an archive of the discontinued LLVM Phabricator instance.

Canonicalize variable usage in testsuite Makefiles
ClosedPublic

Authored by aprantl on Sep 24 2019, 2:03 PM.

Details

Summary

This test streamlines our use of variables that are expected by Makefile.rules throughout the test suite. Mostly it replaced potentially dangerous overrides and updates of variables like CFLAGS with safe assignments to variables reserved for this purpose like CFLAGS_EXTRAS.

Diff Detail

Repository
rL LLVM

Event Timeline

aprantl created this revision.Sep 24 2019, 2:03 PM
aprantl updated this revision to Diff 221592.Sep 24 2019, 2:04 PM

A few things that need checking/reordering, but otherwise great cleanup!

lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/vbool/Makefile
4 ↗(On Diff #221592)

This is wrong ;-) This should probably just go away.

lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/vector/Makefile
4 ↗(On Diff #221592)

Same here

lldb/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values_x86_64/Makefile
3 ↗(On Diff #221592)

Another one

lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/ambiguous_tail_call_seq1/Makefile
3 ↗(On Diff #221592)

These one too?

I checked, and Makefile.rules does initialize CXXFLAGS lazily, but it's still better to not depend on that implementation detail.

aprantl updated this revision to Diff 221613.Sep 24 2019, 3:32 PM

Address feedback from Jonas.

This revision is now accepted and ready to land.Sep 24 2019, 5:20 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 24 2019, 5:35 PM

Hey Adrian,

I've reverted two changes in r372801 that appear to break the linux bots:

http://lab.llvm.org:8014/builders/lldb-x86_64-fedora/builds/2405
http://lab.llvm.org:8014/builders/lldb-x86_64-debian/builds/4417

Can you have a look?

Cool stuff. I wanted to do this for a while. Thanks.