Page MenuHomePhabricator

[LLDB] [PECOFF] Recognize arm64 executables
ClosedPublic

Authored by mstorsjo on Sep 23 2019, 5:25 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Sep 23 2019, 5:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2019, 5:25 AM
compnerd accepted this revision.Sep 23 2019, 8:59 AM
compnerd added inline comments.
lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
202 ↗(On Diff #221302)

Please use aarch64-unknown-windows.

This revision is now accepted and ready to land.Sep 23 2019, 8:59 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2019, 1:42 PM

Since this (unlike most of your other patches in this series) is definitely adding new functionality, it would be good to accompany it with a test. The simplest way to do that should be via something like yaml2obj && lldb-test object-file | FileCheck. I'd recommend looking at lit/Modules/MachO/lc_version_min.yaml for inspiration.