Page MenuHomePhabricator

[LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures
ClosedPublic

Authored by mstorsjo on Sep 23 2019, 5:23 AM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Sep 23 2019, 5:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2019, 5:23 AM

What do you think of adding some sort of notification that hardware breakpoints are currently unsupported and that we are falling back to software breakpoints for the #else case?

lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp
87 ↗(On Diff #221299)

Should this line not also include || defined(__aarch64__) || defined(_M_ARM64)?

mstorsjo marked an inline comment as done.Sep 23 2019, 12:05 PM

What do you think of adding some sort of notification that hardware breakpoints are currently unsupported and that we are falling back to software breakpoints for the #else case?

I guess it could make sense. What kind of notification do you have in mind?

lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp
87 ↗(On Diff #221299)

I guess it should. Or this might be one of the few places where checking for just _WIN64 might be easiest?

I think that printf is quite an amazing notification :-)

lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp
87 ↗(On Diff #221299)

Yeah, I think that _WIN64 is probably the easiest thing indeed.

I think that printf is quite an amazing notification :-)

Ok, I'll make it an LLDB_LOG then, as I'd presume using raw printfs isn't really allowed :-)

mstorsjo updated this revision to Diff 221406.Sep 23 2019, 1:49 PM

Added a log message, changed an x86_64 ifdef into _WIN64.

compnerd accepted this revision.Sep 23 2019, 3:09 PM
This revision is now accepted and ready to land.Sep 23 2019, 3:09 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 24 2019, 1:39 AM