Page MenuHomePhabricator

[LLDB] Avoid warnings about redefining posix mode defines on MinGW
ClosedPublic

Authored by mstorsjo on Sep 23 2019, 5:19 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Sep 23 2019, 5:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2019, 5:19 AM
hhb accepted this revision.Sep 23 2019, 3:36 PM
hhb added inline comments.
lldb/include/lldb/Host/windows/PosixApi.h
39 ↗(On Diff #221298)

Maybe move these into the defined(_MSC_VER) above? Or the other way? Seems they should be consistent.

This revision is now accepted and ready to land.Sep 23 2019, 3:36 PM
mstorsjo marked an inline comment as done.Sep 23 2019, 11:21 PM
mstorsjo added inline comments.
lldb/include/lldb/Host/windows/PosixApi.h
39 ↗(On Diff #221298)

I don't want to move them into the _MSC_VER ifdef above, as there are pretty recent mingw-w64 releases without these new defines as well (the new ones were only added in mingw-w64 v4), but I guess I could change the _MSC_VER ifdef to check for S_IRUSR instead.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 24 2019, 1:40 AM