Page MenuHomePhabricator

[ABISysV] Fix regression for Simulator and MacABI
ClosedPublic

Authored by JDevlieghere on Sep 20 2019, 4:37 PM.

Details

Summary

The ABISysV ABI was refactored in r364216 to support the Windows ABI for x86_64. In particular it changed ABISysV_x86_64::CreateInstance to switch on the OS type. This breaks debugging MacABI apps as well as apps in the simulator. This adds back the necessary cases.

We have a test on Github that exercises this code path and which I'd like to upstream once the remaining MacABI parts become available in clang.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Sep 20 2019, 4:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 20 2019, 4:37 PM
Herald added a subscriber: abidh. · View Herald Transcript
JDevlieghere edited the summary of this revision. (Show Details)Sep 23 2019, 9:29 AM
aprantl accepted this revision.Sep 23 2019, 10:19 AM
aprantl added inline comments.
lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp
233 ↗(On Diff #221134)

Can you add a comment here that this is to support older compilers that don't support the -simulator environment yet?

This revision is now accepted and ready to land.Sep 23 2019, 10:19 AM

What does x86_64-apple-darwin canonicalize to? Do we need an extra case for that?

aprantl added inline comments.Sep 23 2019, 10:23 AM
lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp
231 ↗(On Diff #221134)

clang-format?

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2019, 12:04 PM